feat: Provide support for Geneva in StatsD metric sink #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tomkerkhove
reviewed
Nov 10, 2022
Comment on lines
+22
to
+23
| appKeySecretFilePath: "" # The path to the secret file | ||
| appKeySecretFileName: "" # The file that contains the secret value |
| {{- if eq .Values.metricSinks.statsd.formattertype "custom" }} | ||
| account: {{ .Values.metricSinks.statsd.account | quote }} | ||
| namespace: {{ .Values.metricSinks.statsd.namespace | quote }} | ||
| formattertype: {{ .Values.metricSinks.statsd.formattertype | quote }} |
There was a problem hiding this comment.
This should always be added
tomkerkhove
changed the title
|
@arielhaim83 Are you planning on updating this one or should we abandon it? |
|
Basically it's an example of how to use custom formatter and loading a secret from a file directory, I think we should complete this one |
|
Thanks! Let me know when it's ready for review |
|
@arielhaim83 Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #