Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic tags cannot be added when metric submit #170

Closed
apack1001 opened this issue Dec 10, 2018 · 1 comment
Closed

dynamic tags cannot be added when metric submit #170

apack1001 opened this issue Dec 10, 2018 · 1 comment

Comments

@apack1001
Copy link

Hi,

Our application introduce different labels (tag) at differenct situation. It looks likes:

ademon:1223|g|#k1:k1
ademon:1223|g|#k1:k1,k2:v2

This will lead to a failure like that:

A change of configuration created inconsistent metrics for "ademon". You have to restart the statsd_exporter, and you should consider the effects on your monitoring setup. Error: a previously registered descriptor with the same fully-qualified name as Desc{fqName: "ademon", help: "Metric autogenerated by statsd_exporter.", constLabels: {k1="k1",k2="v2"}, variableLabels: []} has different label names or a different help string","source":"exporter.go:339

Will this feature be supported in the feature, tags can be dynamic added to metric?

If not, may I implement this and contribute this feature to this project

@matthiasr
Copy link
Contributor

In principle this is something I want to support, but it is not easy to implement. The Prometheus client really prefers consistent metrics; I believe we need to convert to the Collector form and ConstMetrics, and make sure to mark the collector as Unchecked. Alternatively/additionally, we could fully handle expanding label sets ourselves but that may some many edge cases that need handling.

In any case, I would wait until #164 is in, it gets us one step closer to this by handling metrics on a name-by-name basis.

This issue is a duplicate of #114, I'll close it in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants