Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of negative thermal_zone temps #283

Closed
dimalo opened this issue Apr 22, 2020 · 2 comments
Closed

Fix parsing of negative thermal_zone temps #283

dimalo opened this issue Apr 22, 2020 · 2 comments

Comments

@dimalo
Copy link

dimalo commented Apr 22, 2020

Hi! I have an issue using node_exporter on an Intel NUCi3BEH running Debian Buster.

$ uname -a
Linux nuc 4.19.0-8-amd64 #1 SMP Debian 4.19.98-1 (2020-01-26) x86_64 GNU/Linux

Setting up lm-sensors and basically hitting enter till the end I get these sensor values:

$ sensors
pch_cannonlake-virtual-0
Adapter: Virtual device
temp1:        +48.0°C

acpitz-acpi-0
Adapter: ACPI interface
temp1:       -263.2°C
temp2:        +27.8°C  (crit = +119.0°C)

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:        +45.0°C  (high = +100.0°C, crit = +100.0°C)
Core 1:        +44.0°C  (high = +100.0°C, crit = +100.0°C)

I'm not running on liquid nitrogen 😄

node_exporter logs give me following error log:

level=error ts=2020-04-22T12:01:48.962Z caller=collector.go:161 msg="collector failed" name=thermal_zone duration_seconds=0.000452796 err="strconv.ParseUint: parsing \"-263200\": invalid syntax"

It seems like procfs expects only uint here
Unfortunately I'm not familier with go so any pro can help out with this?

Surely this fix would be very interesting for the overclocking community or enabling this software for quantum cores or well, just faulty configured NUC devices 😄
Thanks!

@binjip978
Copy link
Contributor

hello, would like to help with this one, opened #287

@pgier
Copy link
Collaborator

pgier commented May 5, 2020

Fixed by #287

@pgier pgier closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants