Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `unpack1' for String (NoMethodError) when use in ruby < 2.4 #315

Closed
xeruzo opened this issue Jul 4, 2024 · 2 comments
Closed

Comments

@xeruzo
Copy link

xeruzo commented Jul 4, 2024

i have a project use ruby 2.3.0, and is ok runing with prometheus before 4.2.3

but in the new version 4.2.3
i find it has new dependency the gem base64 >= 0
and the base64 is use unpack1 method

see this: https://github.com/ruby/base64/blob/v0.1.0/lib/base64.rb

and is now throw a error , can u think to remove dependency the gem base64 in next version or add only limit ruby >= 2.4 can use newest version?

ruby: 2.3.0p0
rails: 5.0.3

gemfile
....
gem 'puma-metrics', '1.2.0'
...

/usr/local/bundle/gems/base64-0.1.1/lib/base64.rb:59:in `decode64': undefined method `unpack1' for "**************":String (NoMethodError)
@Sinjo
Copy link
Member

Sinjo commented Jul 4, 2024

Hey, thanks for reporting this.

I'm afraid Ruby 2.3 dropped off our compatibility list a while ago as it's EOL.

I'm not going to preach to you about upgrading the version of Ruby you use, but versions of this gem have only been working for you by chance since we dropped 2.3 support back in 2020.

@xeruzo
Copy link
Author

xeruzo commented Jul 4, 2024

thx to answer my isse.

use 4.2.2 also can fix my problem

@xeruzo xeruzo closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants