Add ability to filter metrics in DropwizardExports #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
Add comments Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
|
@brian-brazil Hi, could you please review this patch? |
brian-brazil
reviewed
Oct 8, 2020
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Show resolved
Hide resolved
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Show resolved
Hide resolved
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
Code review fixes, split wildcard import into concrete classes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
brian-brazil
reviewed
Oct 9, 2020
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Show resolved
Hide resolved
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Show resolved
Hide resolved
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Show resolved
Hide resolved
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Show resolved
Hide resolved
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <[email protected]>
|
Thanks! |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #573