Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bill of Materials #561

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Add Bill of Materials #561

merged 2 commits into from
Jul 17, 2020

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Jul 15, 2020

Fixes #508.

Fixes #508.

Signed-off-by: Tom Wieczorek <[email protected]>
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient</artifactId>
<version>${project.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use variables, there's some build system out there that can't handle them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, didn't know. Which one?

I'll try to fix that. Without variables, we'll need some special handling for releases, so that versions are changed accordingly. Let's see...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was some years ago, so I don't recall offhand.

I'd expect that mvn would update everything automatically, as it already does that for the other versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The release plugin handles this out of the box just fine. It seems to rewrite versions for all projects in the reactor everywhere. I thought it would just update the parent version.

The maven release plugin handles the version updates in the
dependencyManagement section just fine.

Signed-off-by: Tom Wieczorek <[email protected]>
@brian-brazil brian-brazil merged commit 2009e7d into prometheus:master Jul 17, 2020
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish a BOM
2 participants