-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bill of Materials #561
Conversation
Fixes #508. Signed-off-by: Tom Wieczorek <[email protected]>
simpleclient_bom/pom.xml
Outdated
<dependency> | ||
<groupId>io.prometheus</groupId> | ||
<artifactId>simpleclient</artifactId> | ||
<version>${project.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use variables, there's some build system out there that can't handle them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, didn't know. Which one?
I'll try to fix that. Without variables, we'll need some special handling for releases, so that versions are changed accordingly. Let's see...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was some years ago, so I don't recall offhand.
I'd expect that mvn would update everything automatically, as it already does that for the other versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. The release plugin handles this out of the box just fine. It seems to rewrite versions for all projects in the reactor everywhere. I thought it would just update the parent version.
The maven release plugin handles the version updates in the dependencyManagement section just fine. Signed-off-by: Tom Wieczorek <[email protected]>
Thanks! |
Fixes #508.