Wrap PrintWriter with BufferedWriter #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context.setContextPath("/"); | ||
| context.addServlet(new ServletHolder(new MetricsServlet()), "/metrics"); | ||
|
|
||
| Server server = new Server(1234); |
There was a problem hiding this comment.
Do we actually need to run a HTTP server to test this?
There was a problem hiding this comment.
This hasn't been addressed.
There was a problem hiding this comment.
It's required since bottleneck is container-specific. For example, with Jetty 8.1.7 the bottleneck seems to be the ByteArrayBuffer instances. But with Jetty 9.4.27, ByteArrayBuffer is no longer an issue but another part of the code is consuming CPU cycles. In either case, the wrapper patch improved the performance by approximately the same amount.
There was a problem hiding this comment.
Can we at least bind to 0 so we don't clash with any existing listeners?
Signed-off-by: Takanori Takase <[email protected]>
Signed-off-by: Takanori Takase <[email protected]>
Signed-off-by: Takanori Takase <[email protected]>
after-the-sunrise
force-pushed
the
master
branch
from
52c3624
to
87918da
Compare
Signed-off-by: Takanori Takase <[email protected]>
|
Thanks! |
|
Thanks for the review & merge :) |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @brian-brazil,
Generating servlet output for a large number of metrics seems to be inefficient, since the underlying
PrintWriterimplementation is generating too manyorg.eclipse.jetty.io.ByteArrayBufferinstances.Performance improved by simply wrapping the
PrintWriterwithBufferedWriter. Microbenchmark (ExampleBenchmark, 10k gauges, 100 iterations, laptop machine) shows that it takes around 2.5 sec with the wrapper, and around 5.5 sec without the wrapper.