Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend against too many concurrent scrapes #179

Closed
beorn7 opened this issue Oct 16, 2015 · 1 comment
Closed

Defend against too many concurrent scrapes #179

beorn7 opened this issue Oct 16, 2015 · 1 comment
Assignees
Milestone

Comments

@beorn7
Copy link
Member

beorn7 commented Oct 16, 2015

If the /metrics endpoint is scraped too often concurrently, too much resources are claimed and the monitored binary might OOM because of a rogue monitoring server...

Reducing the resource usage of an individual scrape (e.g. by streaming more and buffering less as we do currently) increases the number of scrapes that can be performed in parallel, but doesn't fundamentally solve the problem. Adding "one more test monitoring server" could still crash production binaries. The HTTP exposition needs to be configurable in terms of max scrapes in flight and scrape timeout.

@beorn7 beorn7 self-assigned this Oct 16, 2015
@beorn7
Copy link
Member Author

beorn7 commented Aug 19, 2016

With the new HandlerOpts, we can add an option for that without a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant