Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric for rcode returned from DNS probe #799

Closed
bennetty opened this issue Jun 9, 2021 · 1 comment
Closed

Metric for rcode returned from DNS probe #799

bennetty opened this issue Jun 9, 2021 · 1 comment

Comments

@bennetty
Copy link

bennetty commented Jun 9, 2021

This is a feature request.

Currently the for the DNS probe, the metric probe_success returned 0/1 based on the success of the probe but i was wondering if it would be of value to return a metric which counts the number of each rcode for example?

this could give greater detail into the failed DNS probe without having to look through the logs.

Fo example:
rate(probe_dns_rcode{rcode="SERVFAIL"}[5m]) > 0.5
vs
rate(probe_dns_rcode{rcode="REFUSED"}[5m]) > 0.5
could give better alerts

If this is a feature that is worth doing, i dont mind trying to implement it. Please let me know what you think :)

@dgl
Copy link
Member

dgl commented Jan 2, 2022

This is covered by #474.

Note using labels would be nice for readability, but is also adding a lot of labels per probe, so I'm looking into doing this with a metric that has the value of the rcode instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants