Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tini from docker image #171

Closed
znerol opened this issue Oct 1, 2023 · 1 comment · Fixed by #179
Closed

Remove tini from docker image #171

znerol opened this issue Oct 1, 2023 · 1 comment · Fixed by #179
Milestone
3.0.0

Comments

@znerol
Copy link
Member

znerol commented Oct 1, 2023

Now that most container runtimes provide the --init option, there is no point packaging tini anymore.

Remove it from the official docker image and update the docs to instruct people to use --init instead.
@znerol znerol added this to the 3.0.0 milestone Oct 1, 2023
@znerol
Copy link
Member Author

znerol commented Oct 1, 2023

This is a potentially breaking change, needs to go into a new major release.

@znerol znerol mentioned this issue Oct 1, 2023
Closed
@znerol znerol mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Remove tini from docker image prometheus-pve/prometheus-pve-exporter
1 participant
@znerol