Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Incorrect NumTombstones after block.Delete(...) #384

Closed
codesome opened this issue Sep 18, 2018 · 1 comment
Closed

Incorrect NumTombstones after block.Delete(...) #384

codesome opened this issue Sep 18, 2018 · 1 comment

Comments

@codesome
Copy link
Contributor

Found this while working on #374

Apparently updating NumTombstones only here is incorrect. For example, if currently there were no stones and we want to add new stones in Delete(...), NumTombstones is nowhere updated.

Please correct me if I am wrong. I will open a PR for this soon.
@gouthamve
Copy link
Collaborator

Yes you are right. This was introduced in this: #212

Please fix it and add a test for the same :)

@codesome codesome mentioned this issue Sep 18, 2018
Merged
@krasi-georgiev krasi-georgiev mentioned this issue Oct 3, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gouthamve @codesome