Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Add metric for the space taken of the symbol tables #244

Closed
brian-brazil opened this issue Jan 5, 2018 · 6 comments
Closed

Add metric for the space taken of the symbol tables #244

brian-brazil opened this issue Jan 5, 2018 · 6 comments

Comments

@brian-brazil
Copy link
Contributor

If a user has way too many label values this could get large, so having a metric indicating the space taken would be useful.

@gouthamve
Copy link
Collaborator

Should this be a prometheus metric or should it be part of the tsdb/promtool cli?

@brian-brazil
Copy link
Contributor Author

A metric of the TSDB itself, as Prometheus has no knowledge of this.

@sipian
Copy link

sipian commented Jan 29, 2018

If there is no one working on this, I would like to take this issue up.

@sipian
Copy link

sipian commented Jan 30, 2018

In index/index.go there is a function, func (r *Reader) SymbolTable() map[uint32]string

Based on my understanding, to get the symbol table size we are supposed to call this function and get the total size of the map[uint32]string. For map total size, I found this reference

Is this the correct direction in solving this issue?

@gouthamve
Copy link
Collaborator

As I spoke offline, this is about the size of the symbol table on disk rather than the in-mem version.

@brian-brazil
Copy link
Contributor Author

Either in-memory or disk works, they're both basically the same size.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants