Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the dotnet_* collectors #300

Closed
carlpett opened this issue Dec 12, 2018 · 1 comment · Fixed by #1633
Closed

Merge the dotnet_* collectors #300

carlpett opened this issue Dec 12, 2018 · 1 comment · Fixed by #1633
Labels

Comments

@carlpett
Copy link
Collaborator

Currently there are 8 dotnet collectors. I believe it would be better to merge these into a single collector, and make it possible to enable/disable "sub-collectors" much like the mssql collector does.

We'll need to consider how we handle the deprecation. I suggest that we handle the translation to the new flag and print a warning for a few versions before dropping the old collector names. For example, having the old flag --collectors.enabled=dotnet_clrjit would have the same effect as --collectors.enabled=dotnet --collector.dotnet.classes-enabled=dotnet (or whatever the flag would be named).
We also need to decide what would be the default sub-collectors. All of them?

@carlpett carlpett added this to the 1.0 milestone Dec 27, 2019
@carlpett carlpett removed the 1.0 label Dec 27, 2019
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant