Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-kube-stack - support targetLabels for node-exporter and kubelet using operator #4966

Closed
kranthikirang opened this issue Nov 4, 2024 · 0 comments · Fixed by #4970 or #4973
Labels
bug Something isn't working

Comments

@kranthikirang
Copy link
Contributor

Describe the bug a clear and concise description of what the bug is.

Currently we are not passing targetLabels to node-exporter serviceMonitor and also no way to create kubelet service with additional labels so that kubelet serviceMinotor can add them to targetLabels in prometheus.

Example:

`prometheus-node-exporter:
service:
labels:
cluster: talos-cluster
prometheus:
monitor:
targetLabels:
- cluster
relabelings:
- sourceLabels: [__meta_kubernetes_endpoint_node_name]
separator: ;
targetLabel: nodename
replacement: $1
action: replace

Where as same is supported in kube-service-metrics exporter.

kube-state-metrics:
customLabels:
cluster: talos-cluster
prometheus:
monitor:
targetLabels:
- cluster
relabelings:
- sourceLabels: [__meta_kubernetes_endpoint_node_name]
separator: ;
targetLabel: nodename
replacement: $1
action: replace`

What's your helm version?

version.BuildInfo{Version:"v3.16.2", GitCommit:"13654a52f7c70a143b1dd51416d633e1071faffb", GitTreeState:"clean", GoVersion:"go1.22.7"}

What's your kubectl version?

Client Version: v1.31.1 Kustomize Version: v5.4.2 Server Version: v1.31.1

Which chart?

kube-prometheus-stack

What's the chart version?

65.5.1

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helm upgrade -i prometheus . -n kube-system -f ./local/overrides.yaml

Anything else we need to know?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant