Fix Prometheus naming convention issues

[SuperQ]

There are a number of metrics that have Prometheus naming issues, for example counters missing _total.

[SuperQ]

CC @repl-mike-roest

[repl-mike-roest]

These were the ones mismatched discovered in #411

elasticsearch_breakers_overhead counter metrics should have "_total" suffix
elasticsearch_breakers_tripped counter metrics should have "_total" suffix
elasticsearch_cluster_health_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_cluster_health_total_scrapes counter metrics should have "_total" suffix
elasticsearch_clustersettings_stats_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_clustersettings_stats_total_scrapes counter metrics should have "_total" suffix
elasticsearch_filesystem_io_stats_device_operations_count counter metrics should have "_total" suffix
elasticsearch_filesystem_io_stats_device_read_operations_count counter metrics should have "_total" suffix
elasticsearch_filesystem_io_stats_device_read_size_kilobytes_sum counter metrics should have "_total" suffix
elasticsearch_filesystem_io_stats_device_write_operations_count counter metrics should have "_total" suffix
elasticsearch_filesystem_io_stats_device_write_size_kilobytes_sum counter metrics should have "_total" suffix
elasticsearch_index_stats_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_indices_completion_size_in_bytes counter metrics should have "_total" suffix
elasticsearch_indices_docs_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_fielddata_evictions counter metrics should have "_total" suffix
elasticsearch_indices_filter_cache_evictions counter metrics should have "_total" suffix
elasticsearch_indices_flush_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_get_exists_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_get_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_query_miss_count counter metrics should have "_total" suffix
elasticsearch_node_stats_total_scrapes counter metrics should have "_total" suffix
elasticsearch_indices_mappings_stats_field_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_indices_request_miss_count counter metrics should have "_total" suffix
elasticsearch_indices_deleted_docs_total non-counter metrics should not have "_total" suffix

elasticsearch_indices_query_miss_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_indices_search_query_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_request_miss_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_indices_search_suggest_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_segment_count_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_segment_fields_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_settings_stats_total_scrapes counter metrics should have "_total" suffix
elasticsearch_indices_segment_points_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_translog_operations counter metrics should have "_total" suffix
elasticsearch_jvm_gc_collection_seconds_count counter metrics should have "_total" suffix
elasticsearch_snapshot_stats_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_indices_segment_index_writer_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_segment_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_segment_version_map_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_filesystem_io_stats_device_operations_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_filesystem_io_stats_device_read_operations_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_filesystem_io_stats_device_write_operations_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_indices_segment_terms_memory_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_segments_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_jvm_gc_collection_seconds_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_filesystem_io_stats_device_write_size_kilobytes_sum non-histogram and non-summary metrics should not have "_sum" suffix
elasticsearch_filesystem_io_stats_device_write_size_kilobytes_sum use base unit "bytes" instead of "kilobytes"
elasticsearch_index_stats_total_scrapes counter metrics should have "_total" suffix
elasticsearch_indices_get_missing_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_query_cache_count counter metrics should have "_total" suffix
elasticsearch_indices_query_cache_evictions counter metrics should have "_total" suffix
elasticsearch_indices_request_cache_count counter metrics should have "_total" suffix
elasticsearch_indices_request_cache_evictions counter metrics should have "_total" suffix
elasticsearch_indices_search_fetch_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_search_scroll_time_seconds counter metrics should have "_total" suffix
elasticsearch_indices_translog_size_in_bytes counter metrics should have "_total" suffix
elasticsearch_jvm_gc_collection_seconds_sum counter metrics should have "_total" suffix
elasticsearch_indices_segment_norms_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_settings_stats_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_jvm_memory_pool_max_bytes counter metrics should have "_total" suffix
elasticsearch_jvm_memory_pool_peak_max_bytes counter metrics should have "_total" suffix
elasticsearch_jvm_memory_pool_peak_used_bytes counter metrics should have "_total" suffix
elasticsearch_node_stats_json_parse_failures counter metrics should have "_total" suffix
elasticsearch_process_cpu_time_seconds_sum counter metrics should have "_total" suffix
elasticsearch_thread_pool_rejected_count counter metrics should have "_total" suffix
elasticsearch_indices_query_cache_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_snapshot_stats_total_scrapes counter metrics should have "_total" suffix
elasticsearch_indices_completion_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_request_cache_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_indices_segment_doc_values_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_segment_fixed_bit_set_memory_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_indices_store_size_bytes_total non-counter metrics should not have "_total" suffix
elasticsearch_process_open_files_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_thread_pool_active_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_thread_pool_largest_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_thread_pool_queue_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_thread_pool_rejected_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_thread_pool_threads_count non-histogram and non-summary metrics should not have "_count" suffix
elasticsearch_filesystem_io_stats_device_read_size_kilobytes_sum non-histogram and non-summary metrics should not have "_sum" suffix
elasticsearch_jvm_gc_collection_seconds_sum non-histogram and non-summary metrics should not have "_sum" suffix
elasticsearch_process_cpu_time_seconds_sum non-histogram and non-summary metrics should not have "_sum" suffix
elasticsearch_filesystem_io_stats_device_read_size_kilobytes_sum use base unit "bytes" instead of "kilobytes"
elasticsearch_thread_pool_completed_count counter metrics should have "_total" suffix
elasticsearch_thread_pool_completed_count non-histogram and non-summary metrics should not have "_count" suffix