Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If publish fails, aspirate still gives success status #41

Closed
timheuer opened this issue Nov 24, 2023 · 1 comment · Fixed by #47
Closed

If publish fails, aspirate still gives success status #41

timheuer opened this issue Nov 24, 2023 · 1 comment · Fixed by #47
Labels
bug Something isn't working

Comments

@timheuer
Copy link
Contributor

🔥 Bug Description

If a publish to a registry fails, the status still indicates succes

🔍 Steps to Reproduce the Bug

  1. Set a registry that is invalit
  2. aspirate generate
    OBSERVE: publish failed but the aspirate status gives me ✔️ vibes
/usr/local/share/dotnet/sdk/8.0.100/Containers/build/Microsoft.NET.Build.Containers.targets(202,5): error :    at
Microsoft.NET.Build.Containers.Tasks.CreateNewImage.PushToRemoteRegistryAsync(BuiltImage builtImage, SourceImageReference
sourceImageReference, DestinationImageReference destinationImageReference, CancellationToken cancellationToken) in
/_/src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs:line 199
[/Users/timheuer/Projects/aspire1/aspire1.ApiService/aspire1.ApiService.csproj]
	(✔) Done:  Building and Pushing container for project apiservice

🧯 Possible Solution

  • Observe the error state of previous commands and mirror correct state
@prom3theu5
Copy link
Owner

That's strange!
Is that the current release of dotnet, or a preview?

Mine when I do that raises error 'CONTAINER1013' - whats strange is it says the same line number as the error yours throws on - at that target
For instance - this is me throwing an image at google lol
image

@prom3theu5 prom3theu5 added the bug Something isn't working label Nov 24, 2023
@prom3theu5 prom3theu5 moved this to Todo in Aspirate Nov 24, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Aspirate Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants