Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better event system #189

Closed
maxleiko opened this issue Mar 10, 2018 · 4 comments
Closed

Better event system #189

maxleiko opened this issue Mar 10, 2018 · 4 comments

Comments

@maxleiko
Copy link
Contributor

WIP maxleiko/react-diagrams

@dylanvorster
Copy link
Member

looks good, not sure about inverting the isCreated logic though since its an API change. FWIW, im about to start a rewrite of the event bus in the next hour or so.

@dylanvorster
Copy link
Member

im going to implement a way model events to trigger repaints in an efficient manner (almost like how mobs uses actions to defer the events. Also going to add a way to cancel an event before it fires)

@maxleiko
Copy link
Contributor Author

To be honest, I just wanted to get notified when links were connected, because as of now, we are just getting events when the link is first created, but not when it is actually connected to a port.
And in the process of refactoring, I found myself changing a bit the API, but that is subject to discussions of course.

But if you actually are going to refactor the event system then I might push this update to later and wait for your modifications.

@maxleiko
Copy link
Contributor Author

Closing this as no longer necessary.

In order to get notified when a link is connected, one can use the targetPortChanged event triggered on link listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants