[BUG] Stack overflow when adding large number of items to static ImmutableMap

[jchafik]

Describe the bug
When including Lombok as a dependency, a stack overflow exception is thrown when attempting to initialize too many items in a static ImmutableMap.builder() property.

Locally, this fails when adding more than 436 items. However, the failure point would be platform dependent and based on the configured thread stack size (-Xss / XX:ThreadStackSize).

To Reproduce

package lombok;

import java.util.Map;
import com.google.common.collect.ImmutableMap;

public interface TestConstants
{
    public static final Map<String, String> TEST_STACK_OVERFLOW = ImmutableMap.<String, String>builder()
            .put("1", "")
            .put("2", "")
            ...
            .put("437", "")
            .build();
}

Stack trace excerpt

Caused by: java.lang.StackOverflowError
    at lombok.javac.JavacAST.drill (JavacAST.java:426)
    at lombok.javac.JavacAST.buildStatementOrExpression (JavacAST.java:392)
    at lombok.javac.JavacAST.buildTree (JavacAST.java:201)
    at lombok.javac.JavacAST.buildTree (JavacAST.java:1)
    at lombok.core.AST.buildWithCollection (AST.java:425)
    at lombok.core.AST.buildWithField0 (AST.java:399)
    at lombok.core.AST.buildWithField (AST.java:292)
    at lombok.javac.JavacAST.drill (JavacAST.java:426)
    at lombok.javac.JavacAST.buildStatementOrExpression (JavacAST.java:392)
    at lombok.javac.JavacAST.buildTree (JavacAST.java:201)
    at lombok.javac.JavacAST.buildTree (JavacAST.java:1)
    at lombok.core.AST.buildWithField0 (AST.java:394)
    at lombok.core.AST.buildWithField (AST.java:292)

Expected behavior
The class should compile without error (as it does when excluding Lombok as a dependency)

Version info (please complete the following information):

• Lombok version 1.18.16
• javac running openjdk 11.0.9 2020-10-20
• Google Guava 30.0-jre

[Rawi01]

Thanks for reporting, this is a duplicate of #2453, #1171, #1118. Replacing these recursive function calls is not that easy...

[rspilker]

Well, it might be by externalizing the stack. I'll have a look at it.

[rspilker]

I'm closing all duplicates of #1118