Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add earlier activity" dialog no longer shows up from Shell extension #548

Closed
Forage opened this issue Feb 11, 2020 · 7 comments · Fixed by #549
Closed

"Add earlier activity" dialog no longer shows up from Shell extension #548

Forage opened this issue Feb 11, 2020 · 7 comments · Fixed by #549
Milestone

Comments

@Forage
Copy link
Contributor

Forage commented Feb 11, 2020

With the 3.0-beta, clicking on the "Add earlier activity" menu entry from the GNOME Shell extension no longer makes the dialog pop up. Other entries like the overview and settings work as expected.

An intermediate build on 30 October worked as expected.
Calling the same dialog from the overview dialog works as well.

Is there any way I can have a Shell extension provide me with log messages?
Could this be another case of some outdated/duplicate files lingering somewhere due to file/folder name changes?

@ederag
Copy link
Collaborator

ederag commented Feb 11, 2020

Thank you for the report, it's good to have early testing, especially for the shell-extension !
(still none here...)

Is there any way I can have a Shell extension provide me with log messages?

No idea.

clicking on the "Add earlier activity"

OK, thanks for that.
Following the track leads to
this and this
ending with editSync which is not explicitly defined.

It was my mistake to remove the edit method in #538.

@ederag
Copy link
Collaborator

ederag commented Feb 11, 2020

@Forage #549 should allow you to continue using the extension,
(dbus interface tested with d-feet only)
but the real "edit" (of a specific fact) will be less simple.
I'll get back to that this evening or tomorrow.

@mwilck
Copy link
Contributor

mwilck commented Feb 11, 2020

The extension tries to open the "edit" method of org.gnome.Hamster.WindowServer and fails:

method call time=1581452687.413741 sender=:1.252 -> destination=:1.259 serial=495 path=/org/gnome/Hamster/WindowServer; interface=org.gnome.Hamster.WindowServer; member=edit
    variant       int32 0
error time=1581452687.414817 sender=:1.259 -> destination=:1.252  error_name=org.freedesktop.DBus.Error.UnknownMethod reply_serial=495
string "Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/dbus/service.py", line 658, in _message_cb
(candidate_method, parent_method) = _method_lookup(self, method_name, interface_name)
File "/usr/lib/python3.7/site-packages/dbus/service.py", line 248, in _method_lookup
  raise UnknownMethodException('%s is not a valid method of interface %s' % (method_name, dbus_interface))
  dbus.exceptions.UnknownMethodException: org.freedesktop.DBus.Error.UnknownMethod: Unknown method: edit is not a valid method of interface org.gnome.Hamster.WindowServer

@mwilck
Copy link
Contributor

mwilck commented Feb 11, 2020

I guess it's caused by commit 0cffe9c.

@mwilck
Copy link
Contributor

mwilck commented Feb 11, 2020

Argh, I should have read more carefully. You tracked that down already... Sorry.

@GeraldJansen
Copy link
Contributor

I can confirm that (temporarily) reverting 0cffe9c gets the edit buttons and Add Earlier Activity menu item working also in xfce-hamster-plugin. Nearly everything seems to be working with the plugin, so Yay!

@ederag
Copy link
Collaborator

ederag commented Feb 15, 2020

Now fixed in #549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants