Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing installation directories and names? #472

Closed
ederag opened this issue Nov 5, 2019 · 2 comments
Closed

Changing installation directories and names? #472

ederag opened this issue Nov 5, 2019 · 2 comments
Milestone

Comments

@ederag
Copy link
Collaborator

ederag commented Nov 5, 2019

A question about names and directories needs to be answered for the migration to GSettings (#470).

Current state

After looking into history, the hamster-time-tracker directories are there since v1,

bld.install_files('${LIBDIR}/hamster-time-tracker',

together with the same affiliations
target= "org.gnome.hamster.service",

and DBus name
bus_name = dbus.service.BusName("org.gnome.Hamster", bus=self.bus)

This was perhaps in opposition to the old hamster-applet ?

Discrepancy

Yet this raised a question:
is the name of the application Hamster,
as the executable and python module names suggest,
or
is the name HamsterTimeTracker as the package name and other directories suggest ?

There has been no concern about these names/directories discrepancy
so we could continue like that.

But if v3.0 must be also a migration to GSettings (that needs a decision on names),
then it is also the best opportunity to ensure consistency.

Proposition

We could change all directory names to hamster,
simply name the application Hamster,
and keep the org.gnome.Hamster affiliation,
both for the DBus interface and the GSettings Schemas.

This is open for discussion.

@ederag
Copy link
Collaborator Author

ederag commented Nov 23, 2019

No objection, so let's do this.

@ederag
Copy link
Collaborator Author

ederag commented Nov 26, 2019

Done, thanks to @GeraldJansen for PR #485 !

@ederag ederag closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant