-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cumbersome to edit time [regression] #439
Comments
Just a guess, but I think the new approach of specifying times on the activity input line was done to harmonize input in the hamster edit windows and the gnome hamster-shell-extension. Personally I really like the new method, because it is very keyboard friendly. With the current master branch (i.e. later than v2.2.2), the start-end times are highlighted when you open the update window. A single keystroke moves you to the start or end and a space deletes the time(s). New times can be entered as 4 digits without the ':'. Together with other keyboard shortcuts (#230, #387) and a window manager shortcut to open the hamster overview window, I now mainly use hamster through the keyboard. |
Hmm... Alright. I guess I'll have to test the new code and see how it feels. For me I saw two fairly different use cases here, that the old UI catered to:
|
I'm still irritated by the single input field. I really like it in the hamster-shell-extension, where I can quickly start and enter tasks. I also see the point on the CLI. For editing past and running tasks in the panel I would prefer separate input fields. Just my 2 cents |
@CendioOssman and @WBTMagnum, One idea would be to separate "Add" and "Edit", not satisfying because cloning is in-between. Not forgetting the original issue; would it be alleviated by point 3 of this proposition ? Bottom line: understood, not easy, lots of hard changes already being worked on, please be patient. |
Being able to use the mouse only would be preferred. The reason being that it's always annoying to have to switch. And you have to use the mouse to select the entry you want to modify and then click to edit. So being able to finish your task without switching to the keyboard would be very nice. That would also include things like clicking on the activity text and getting good suggestions for the scenario where you've entered the wrong one.
Of course. I'm only filing this issue to make sure my use case isn't completely overlooked. :) |
That's exactly why it is now possible to do everything through keyboard, But again, I understand the need for well isolated edition of fields. |
Just to clarify @ederag's response that this is possible through the keyboard, for others that might be interested, just use the Up or Down keys to move through the list (Up first to start from bottom and Down first to start from top), move to the row of interest then press Enter to open the Edit Activity dialog. Admittedly this is not obvious and documentation is needed. |
Good news. |
Hopefully fixed with PR #461. |
Great. I'm a bit swamped right now, but I'll try to get some testing done as soon as I'm able. Unfortunately it is likely it won't be until next week or the week after that. |
@CendioOssman That's fully understandable, thanks for letting us know. |
@CendioOssman PR #461 is far from perfect, but seems to have converged. |
Sorry for the delay. The new interface looks really nice. Fantastic work. :) This should satisfy my needs with regard to editing time. From what I can tell I can keep my workflow from 1.04 without any substantial change. |
Solved by #461. |
It seems the 2.x code lost the separate input widgets for start and end time. This makes it rather annoying to modify time as the previous interface had quick suggestions for common intervals.
It looks like this was removed in 697a03e. But I don't see any rationale. Did someone consider the feature pointless? Or was it removed because no one had ported the supporting code?
Would a PR be accepted returning the old behaviour?
The text was updated successfully, but these errors were encountered: