Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumbersome to edit time [regression] #439

Closed
CendioOssman opened this issue Sep 3, 2019 · 15 comments
Closed

Cumbersome to edit time [regression] #439

CendioOssman opened this issue Sep 3, 2019 · 15 comments
Milestone

Comments

@CendioOssman
Copy link
Contributor

It seems the 2.x code lost the separate input widgets for start and end time. This makes it rather annoying to modify time as the previous interface had quick suggestions for common intervals.

It looks like this was removed in 697a03e. But I don't see any rationale. Did someone consider the feature pointless? Or was it removed because no one had ported the supporting code?

Would a PR be accepted returning the old behaviour?

@CendioOssman
Copy link
Contributor Author

How it looks in 1.04:

2019-09-03-152142_3840x1200_scrot

@GeraldJansen
Copy link
Contributor

GeraldJansen commented Sep 3, 2019

Just a guess, but I think the new approach of specifying times on the activity input line was done to harmonize input in the hamster edit windows and the gnome hamster-shell-extension.

Personally I really like the new method, because it is very keyboard friendly. With the current master branch (i.e. later than v2.2.2), the start-end times are highlighted when you open the update window. A single keystroke moves you to the start or end and a space deletes the time(s). New times can be entered as 4 digits without the ':'. Together with other keyboard shortcuts (#230, #387) and a window manager shortcut to open the hamster overview window, I now mainly use hamster through the keyboard.

Screenshot_2019-09-03_19-10-30

@CendioOssman
Copy link
Contributor Author

Hmm... Alright. I guess I'll have to test the new code and see how it feels.

For me I saw two fairly different use cases here, that the old UI catered to:

  • Starting a new activity, where a single input field with some syntax shortcuts was/is fantastic
  • Editing/correcting an existing entry where it was more important to quickly adjust just a single detail without having to risk other information (which hopefully were already correct)

@WBTMagnum
Copy link

I'm still irritated by the single input field. I really like it in the hamster-shell-extension, where I can quickly start and enter tasks. I also see the point on the CLI. For editing past and running tasks in the panel I would prefer separate input fields.

Just my 2 cents

@ederag
Copy link
Collaborator

ederag commented Sep 10, 2019

@CendioOssman and @WBTMagnum,
thanks for explaining well why separate fields for editing are important,
all the more if you are using overview mainly for editing.
As @GeraldJansen nicely expressed, the command-line style entry has some advantages though.

One idea would be to separate "Add" and "Edit", not satisfying because cloning is in-between.
Maybe we could combine them ?
Got some ideas, need some time before discussing them.

Not forgetting the original issue; would it be alleviated by point 3 of this proposition ?
Or is the goal to be able to enter the end just with mouse ?

Bottom line: understood, not easy, lots of hard changes already being worked on, please be patient.

@CendioOssman
Copy link
Contributor Author

Not forgetting the original issue; would it be alleviated by point 3 of this proposition ?
Or is the goal to be able to enter the end just with mouse ?

Being able to use the mouse only would be preferred. The reason being that it's always annoying to have to switch. And you have to use the mouse to select the entry you want to modify and then click to edit. So being able to finish your task without switching to the keyboard would be very nice. That would also include things like clicking on the activity text and getting good suggestions for the scenario where you've entered the wrong one.

Bottom line: understood, not easy, lots of hard changes already being worked on, please be patient.

Of course. I'm only filing this issue to make sure my use case isn't completely overlooked. :)

@ederag
Copy link
Collaborator

ederag commented Sep 11, 2019

always annoying to have to switch

That's exactly why it is now possible to do everything through keyboard,
including selection of the entry to be modified.
Tab traversal improvements are planned.

But again, I understand the need for well isolated edition of fields.
Suggestions to allow mouse-only edition would be nice then, indeed.

@GeraldJansen
Copy link
Contributor

And you have to use the mouse to select the entry you want to modify and then click to edit.

Just to clarify @ederag's response that this is possible through the keyboard, for others that might be interested, just use the Up or Down keys to move through the list (Up first to start from bottom and Down first to start from top), move to the row of interest then press Enter to open the Edit Activity dialog. Admittedly this is not obvious and documentation is needed.

@ederag ederag added this to the v3.0 milestone Sep 22, 2019
@ederag
Copy link
Collaborator

ederag commented Sep 22, 2019

Good news. TimeInput is still almost functional (not pushed yet). Should be there in v3.0.

@ederag
Copy link
Collaborator

ederag commented Oct 5, 2019

Hopefully fixed with PR #461.
Please provide feedback there.

@CendioOssman
Copy link
Contributor Author

Great. I'm a bit swamped right now, but I'll try to get some testing done as soon as I'm able. Unfortunately it is likely it won't be until next week or the week after that.

@ederag
Copy link
Collaborator

ederag commented Oct 14, 2019

@CendioOssman That's fully understandable, thanks for letting us know.
@WBTMagnum, @Forage Your feedback on design decisions in #461 would be welcome as well.

@ederag
Copy link
Collaborator

ederag commented Oct 23, 2019

@CendioOssman PR #461 is far from perfect, but seems to have converged.
It could be merged this week-end, but given your past contributions, especially on completion,
it looks just fair to give you another opportunity to comment; would you like another week ?

@CendioOssman
Copy link
Contributor Author

Sorry for the delay. The new interface looks really nice. Fantastic work. :)

This should satisfy my needs with regard to editing time. From what I can tell I can keep my workflow from 1.04 without any substantial change.

@ederag
Copy link
Collaborator

ederag commented Oct 30, 2019

Solved by #461.
Thanks for the report !

@ederag ederag closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants