Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

existing activities starting with the # character are displayed blank and new activities starting with # cannot be added #423

Closed
pwhipp opened this issue Jul 17, 2019 · 10 comments · Fixed by #482
Labels
Milestone

Comments

@pwhipp
Copy link

pwhipp commented Jul 17, 2019

Try adding an activity and typing # as the first character. The Save option is enabled but clicking it has no effect.

If you import a db (or update one for testing) with the # character as the first character in an activity, the activity appears as a blank entry.

@ederag
Copy link
Collaborator

ederag commented Jul 18, 2019

Confirmed, thanks for the report !
Way to reproduce, from the command line:

> hamster track #123
Error: please specify activity

Adding the bug label because that used to work in v1,
and any old database should work out of the box.

@ederag
Copy link
Collaborator

ederag commented Sep 12, 2019

With PR #440, facts starting with # already present in the database are read and displayed correctly.
That's a first step.

@ederag ederag added this to the v3.0 milestone Sep 21, 2019
@ederag ederag mentioned this issue Oct 5, 2019
4 tasks
@mwilck
Copy link
Contributor

mwilck commented Oct 25, 2019

IMO this is not a bug. '#' as first character indicates a tag. Every person who as ever used or read twitter should be able to grasp that concept. Why is it important to be able to have activities start with '#'?

@GeraldJansen
Copy link
Contributor

Because #nnn is also often used to refer to an issue or PR in some issue tracking software I suppose. In the past there has been work on integrating Hamster with Redmine, for example.

@mwilck
Copy link
Contributor

mwilck commented Oct 25, 2019

We can of course discuss exchanging '#' for a different character. We could even make it configurable I guess. But the choice of '#' has always made a lot of sense to me, personally.

Hey, myself I'm working on such issues almost all day. I use '123456@Issues'. I've never felt the need to use '#123456@Issues' instead. Sure, that's a matter of taste. But how long is it that hamster has been using '#' for marking tags? Probably as long as tags have been supported at all.

@mwilck
Copy link
Contributor

mwilck commented Oct 25, 2019

@GeraldJansen, has that Redmine integration work ever lead to anything usable? Is it an active project?

@GeraldJansen
Copy link
Contributor

@mwilck At least one group has used Redmine integration in the past. The project is inactive, like Hamster itself for lengthy periods ;-) Actually, I don't even know if they used the #nnn in activity names. I was just trying give some possible reasons for this request. I guess it is a "bug" if it worked in the past and no longer works as expected.

@ederag
Copy link
Collaborator

ederag commented Nov 1, 2019

#466 should allow for activities starting with a #.
Beware that doing so, you'll be confined to separate fields for this fact.
(losing quickness of the cmdline, cf. #467)
That is tracked in #465 and will be hopefully be solved in a future version.

@ederag
Copy link
Collaborator

ederag commented Nov 16, 2019

Should be fully fixed by the #475 parser change.

@ederag ederag mentioned this issue Nov 23, 2019
2 tasks
@ederag
Copy link
Collaborator

ederag commented Nov 25, 2019

Better fix in #482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants