Regex validation for tls secretName fails when using tls delegations

[arminbuerkle]

What steps did you take and what happened:

We deployed contour/deployment/common/common.yaml to our cluster and added an ingress route with a tls secret which referenced a different namespace.

It failed with

spec.virtualhost.tls.secretName in body should match '^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$'

What did you expect to happen:

Creating an IngressRoute with a namespaced tls secretName should work with the addition of TLSCertificateDelegation.

Anything else you would like to add:

We're using the following regex for now:

^[a-z0-9]([-a-z0-9]*[a-z0-9])?([\.\/][a-z0-9]([-a-z0-9]*[a-z0-9])?)*$

Although it's not perfect since test/hello/world would also match although it shouldn't.

---

Yaml files for testing:

---
apiVersion: contour.heptio.com/v1beta1
kind: IngressRoute
metadata:
  name: example-6kqcb
  namespace: example
spec:
  routes: []
  tcpproxy:
    services:
    - name: mys-service
      port: 8080
  virtualhost:
    fqdn: wildcard.example.com
    tls:
      secretName: heptio-contour/wildcard-cert
---
apiVersion: contour.heptio.com/v1beta1
kind: TLSCertificateDelegation
metadata:
  name: wildcard-cert
  namespace: heptio-contour
spec:
  delegations:
  - secretName: wildcard-cert
    targetNamespaces:
    - '*'
---
apiVersion: v1
data:
  tls.crt: aGVsbG8K
  tls.key: Z2l0aHViCg==
kind: Secret
metadata:
  name: wildcard-cert
  namespace: heptio-contour
type: kubernetes.io/tls

Environment:

• Contour version:
  gcr.io/heptio-images/contour:v0.10.0
• Kubernetes version: v1.12

[davecheney]

Thank you for your PR. Please send a PR to update the regex, or just remove the verification entirely for that field.