Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upstream support for PROXYv2 #902

Closed
2 tasks done
rosskukulinski opened this issue Feb 19, 2019 · 11 comments
Closed
2 tasks done

Add upstream support for PROXYv2 #902

rosskukulinski opened this issue Feb 19, 2019 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@rosskukulinski
Copy link
Contributor

rosskukulinski commented Feb 19, 2019 •
edited by skriss
Loading

Describe the solution you'd like

As a platform operator, I would like to use Contour at the border/edge of all my regions (e.g. it has a public IP address). Contour will terminate HTTP1.1, HTTP2.0, GRPC, WebSocket, TCP, HTTPS, etc.

Then I would like it to proxy the connection to backend Ingress Controllers that run in each upstream Kubernetes cluster which may or may not be Contour. This proxying should be done with the PROXYv2 protocol so that connection metadata (client IP address, mTLS SAN, etc) are passed onto the upstream ingress controller.

Blocked
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 19, 2019
@davecheney
Copy link
Contributor

At the moment I don't believe Envoy offers the option to encapsulate an upstream, Envoy's word for Envoy to Pod traffic, TCP session in a PROXYv2 header. This is a blocker for adding this feature to Contour.

@davecheney davecheney removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 13, 2019
@davecheney davecheney removed the ZD1344 label Apr 9, 2019
@davecheney
Copy link
Contributor

Hello,

Without support for PROXYv2 in envoy we cannot implement this feature. I would prefer not to leave this issue open indefinitely as there are no active plans to work on it. If/when upstream implements PROXYv2 support towards backends please reopen this issue.

@discostur
Copy link

In the envoy project on github there is already some effort on implementing proxy protocl for upstreams, for example

envoyproxy/envoy#4128
envoyproxy/envoy#173

I will check later on and post again if envoy has completed the implementation...

@davecheney
Copy link
Contributor

davecheney commented Jul 8, 2019 •
edited
Loading

Thank you for the reference to the Envoy issue. I'll reopen this and target it for beta1, hopefully Envoy 1.11 will be out by then.

@davecheney davecheney reopened this Jul 8, 2019
@davecheney davecheney modified the milestones: 1.0.0-rc.1, 1.0.0-beta.1 Jul 8, 2019
@davecheney davecheney modified the milestones: 1.0.0-beta.1, 0.15.0 Aug 1, 2019
@davecheney
Copy link
Contributor

Moving to 0.15 as the envoy 1.11.0 upgrade is complete #1242

Marking as help wanted because nobody is scheduled to work on this at the moment.

@davecheney davecheney added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. and removed blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. labels Aug 1, 2019
@davecheney
Copy link
Contributor

It looks like this feature is in master, but not 1.11. I'm moving this issue to the unplanned milestone as it is blocked on #1351

@davecheney davecheney modified the milestones: 0.15.0, Unplanned Aug 19, 2019
@davecheney davecheney added blocked Blocked waiting on a dependency and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 19, 2019
@bgagnon
Copy link
Contributor

bgagnon commented Oct 26, 2020

PROXY support for upstream sockets (envoyproxy/envoy#1031) has now landed in Envoy (envoyproxy/envoy#12762).

@youngnick youngnick added lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. and removed blocked Blocked waiting on a dependency labels Oct 27, 2020
@youngnick
Copy link
Member

I've put this one back into "needs triage" so that we can reevaluate where it's at and try to get it prioritized.

@jpeach
Copy link
Contributor

jpeach commented Nov 18, 2020

xref #2529

@youngnick youngnick removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Nov 18, 2020
@skriss skriss removed this from the Backlog milestone Jul 25, 2022
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2024
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@davecheney @jpeach @bgagnon @rbankston @discostur @rosskukulinski @skriss @youngnick