Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make downstream Listener connection limit configurable #5654

Closed
sunjayBhatia opened this issue Aug 3, 2023 · 6 comments · Fixed by #6058
Closed

Make downstream Listener connection limit configurable #5654

sunjayBhatia opened this issue Aug 3, 2023 · 6 comments · Fixed by #6058
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sunjayBhatia
Copy link
Member

Please describe the problem you have

This is often useful for large installations in order to manage resources, prevent DDOS, etc. and falls in line with Envoys edge proxy guidelines: https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge

This is an explicit follow on from #4717 to make key edge best practices configurable

@sunjayBhatia sunjayBhatia added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2023
@sunjayBhatia sunjayBhatia added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2023
@flawedmatrix
Copy link
Contributor

Hi, we'd like help out and work on this issue.

@sunjayBhatia sunjayBhatia removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Jan 4, 2024
@sunjayBhatia
Copy link
Member Author

thanks @flawedmatrix @christianang!

@sunjayBhatia
Copy link
Member Author

hm, github won't let me assign both of yall atm

@sunjayBhatia
Copy link
Member Author

@flawedmatrix @christianang I may have misspoke when we chatted about configuring Listener downstream connection limits, I don't believe it can be done by a field on the Listener object itself, rather via "runtime" configuration: https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/runtime

@sunjayBhatia
Copy link
Member Author

there is a global downstream connection limit available to configure, that we could maybe make a follow-on issue for: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/resource_monitors/downstream_connections/v3/downstream_connections.proto.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants