Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint job is failing #2340

Closed
davecheney opened this issue Mar 16, 2020 · 3 comments
Closed

golangci-lint job is failing #2340

davecheney opened this issue Mar 16, 2020 · 3 comments
Milestone
1.3.0

Comments

@davecheney
Copy link
Contributor 

$ make lint
Running Go linter ...
Unable to find image 'golangci/golangci-lint:latest' locally
latest: Pulling from golangci/golangci-lint

Status: Downloaded newer image for golangci/golangci-lint:latest
fatal error: runtime: out of memory

golangci-lint job is exploding in CI.
@davecheney davecheney added this to the 1.3.0 milestone Mar 16, 2020
@davecheney davecheney assigned davecheney and unassigned davecheney Mar 16, 2020
@davecheney davecheney mentioned this issue Mar 16, 2020
Merged
@davecheney
Copy link
Contributor Author

The recently release 1.24.0 release includes an update to static check, https://github.com/golangci/golangci-lint/releases/tag/v1.24.0, this might be causing the OOM

@davecheney
Copy link
Contributor Author

golangci/golangci-lint#994

@jpeach
Copy link
Contributor

jpeach commented Mar 20, 2020

Fixed in #2341

@jpeach jpeach closed this as completed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@davecheney @jpeach