Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Operator should allow setting AWS ELB/NLB annotations #399

Open
xaleeks opened this issue Jul 7, 2021 · 1 comment
Open

Operator should allow setting AWS ELB/NLB annotations #399

xaleeks opened this issue Jul 7, 2021 · 1 comment
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. aws kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@xaleeks
Copy link

xaleeks commented Jul 7, 2021

I’d like to be able to pass annotations for the AWS ELB (https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/service/annotations/) down to the load balancer. The annotations are typically defined on the service object itself but since the service for the LB is created and managed by the Operator, it’d be good to be able to declaratively set these instead of patching after the object is deployed.

Imagine something like

spec:
 gatewayClassRef: vdp-contour-int
 ingressClassName: vdp-contour-int
 networkPublishing:
   envoy:
     type: LoadBalancerService
     loadBalancer:
       annotations:
         service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'
         service.beta.kubernetes.io/aws-load-balancer-access-log-enabled: "true"
         service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
       providerParameters:
         type: AWS
       scope: Internal

@xaleeks xaleeks added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. aws labels Jul 7, 2021
@xaleeks xaleeks added the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Jul 7, 2021
@stevesloka
Copy link
Member

// projectcontour/contour#3702

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. aws kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

No branches or pull requests

2 participants