Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-card): selected color #1026

Merged
merged 6 commits into from
Nov 29, 2024
Merged

fix(document-card): selected color #1026

merged 6 commits into from
Nov 29, 2024

Conversation

MitanOmar
Copy link
Member

No description provided.

@MitanOmar MitanOmar requested a review from czosel November 22, 2024 15:32
@MitanOmar MitanOmar self-assigned this Nov 22, 2024
@czosel
Copy link
Contributor

czosel commented Nov 22, 2024

Can you add a screenshot?

@MitanOmar
Copy link
Member Author

image

@MitanOmar
Copy link
Member Author

@czosel something else i am thinking about it, the list view is the default view, and when switching to grid view, and then refreshing the page, the view back to list view.

do you think that we should save this status in the URL as query parameter ?

@czosel
Copy link
Contributor

czosel commented Nov 22, 2024

Looks great! Yeah I think a query parameter would make a lot of sense 👍

@MitanOmar MitanOmar force-pushed the fix-select-documents-in-grid-view branch from 3f662a8 to 0823dae Compare November 22, 2024 18:20
czosel
czosel reviewed Nov 25, 2024
View reviewed changes
addon/controllers/index.js Outdated Show resolved Hide resolved
czosel
czosel reviewed Nov 25, 2024
View reviewed changes
addon/routes/index.js Outdated Show resolved Hide resolved
@MitanOmar MitanOmar requested a review from czosel November 26, 2024 13:11
@czosel czosel merged commit d8b1039 into main Nov 29, 2024
10 checks passed
@czosel czosel deleted the fix-select-documents-in-grid-view branch November 29, 2024 08:06
adfinisbot pushed a commit that referenced this pull request Nov 29, 2024
@semantic-release-bot
chore(release): 10.1.0 [skip ci]
855d17a 
# [10.1.0](v10.0.4...v10.1.0) (2024-11-29)

### Bug Fixes

* **document-card:** selected color ([#1026](#1026)) ([d8b1039](d8b1039))

### Features

* emulate production left space of hosted app ([#1013](#1013)) ([417f891](417f891))
@adfinisbot
Copy link
Collaborator

🎉 This issue has been resolved in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czosel czosel czosel approved these changes

Assignees

@MitanOmar MitanOmar

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MitanOmar @czosel @adfinisbot