Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bootstrap 4.0 #1827

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Update to Bootstrap 4.0 #1827

merged 1 commit into from
Jan 22, 2018

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jan 18, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 94.473% when pulling 42e5bcb on bootstrap4 into 169d3b2 on master.

@jcoyne
Copy link
Member

jcoyne commented Jan 19, 2018

You can get around these errors by adding something like this: https://github.com/samvera/hyrax/pull/2511/files

@cbeer
Copy link
Member Author

cbeer commented Jan 19, 2018

Yep, I have that over in #1826.

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.567% when pulling edd966f on bootstrap4 into 9571e5d on master.

@jcoyne jcoyne merged commit ae9188b into master Jan 22, 2018
@jcoyne jcoyne deleted the bootstrap4 branch January 22, 2018 13:20
ConnorSheremeta added a commit to ConnorSheremeta/blacklight that referenced this pull request May 9, 2019
@ConnorSheremeta
Upgrade to bootstrap 4
613d2a2 
- Mirrored work done for bootstrap upgrade from blacklight's PR's projectblacklight#1497, projectblacklight#1564, projectblacklight#1608, projectblacklight#1610, projectblacklight#1819, projectblacklight#1827, projectblacklight#1931, and projectblacklight#1959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbeer @coveralls @jcoyne