Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant up needs a library #44

Open
amitkrout opened this issue Oct 6, 2016 · 2 comments
Open

Vagrant up needs a library #44

amitkrout opened this issue Oct 6, 2016 · 2 comments

Comments

@amitkrout
Copy link
Contributor

amitkrout commented Oct 6, 2016

Currently vagrant up is included in the vagrant sanity test, it would better to have this functionality in the library so that other test can easily use it

@hferentschik
Copy link

Can you please expand on this? Where is the code you are referring to? Didn't you create/use a vagrant wrapper already?

@amitkrout
Copy link
Contributor Author

Currently using two wrapper functions for vagrant up without subscription and with subscription in multiple files such as adb-test/cdk-testsuite/tests/vagrant_sanity.py, vagrant_sshfs.py and openshiftSanity.py file which is not the structure we suppose to do. So creating a single function vagrant_up() in vagrant library with different argument would really helpful to avoid duplicate function.
For example :

def vagrant_up(self, VAGRANTFILE_DIR, PROVIDER, RHN_USERNAME, RHN_PASSWORD, registration_required = False)
If RHN registration is required just pass the argument "registration_required = True" instead of "False". So it will be easy to call the function in different test file to avoid duplication. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants