#780-[ENHANCEMENT] Replace "findViewById" by "@BindView" #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swati4star
requested changes
Oct 28, 2019
Android/app/src/main/java/io/github/project_travel_mate/MainActivity.java
Outdated
Show resolved
Hide resolved
Android/app/src/main/java/io/github/project_travel_mate/MainActivity.java
Outdated
Show resolved
Hide resolved
Android/app/src/main/java/io/github/project_travel_mate/MainActivity.java
Outdated
Show resolved
Hide resolved
Android/app/src/main/java/io/github/project_travel_mate/SplashActivity.java
Outdated
Show resolved
Hide resolved
Android/app/src/main/java/io/github/project_travel_mate/destinations/CityFragment.java
Outdated
Show resolved
Hide resolved
| @@ -81,7 +84,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
| setContentView(R.layout.activity_hotels); | |||
|
|
|||
| Toolbar toolbar = findViewById(R.id.toolbar); | |||
|
|
|||
There was a problem hiding this comment.
dont mark the conversation resolved, if you havent taken any action against it
Android/app/src/main/java/io/github/project_travel_mate/utilities/CurrencyListViewActivity.java
Show resolved
Hide resolved
| @@ -119,7 +119,7 @@ public boolean onCreateOptionsMenu(Menu menu) { | |||
|
|
|||
| public void createCode() { | |||
|
|
|||
| ImageView qrCodeView = findViewById(R.id.im); | |||
There was a problem hiding this comment.
where is this being initialized?
| @@ -102,4 +102,4 @@ private void onItemAutocompleteItemSelected() { | |||
| this.setSelectedText(TimeZone.getTimeZone(this.mAutoCompleteTextViewTimezone.getText().toString())); | |||
| } | |||
|
|
|||
| } | |||
| } | |||
Android/app/src/main/java/io/github/project_travel_mate/utilities/TimezoneListViewActivity.java
Show resolved
Hide resolved
removed import butterknife.Optional;
Removed unused butterknife import
…mes for default fields
Swati4star
requested changes
Oct 29, 2019
| @BindView(R.id.toolbar) | ||
| Toolbar toolbar; | ||
| @BindView(R.id.drawer_layout) | ||
| DrawerLayout Drawer; |
There was a problem hiding this comment.
variable names shouldnt start with capital letter
drawerlayout
| @BindView(R.id.drawer_layout) | ||
| DrawerLayout Drawer; | ||
| @BindView(R.id.nav_view) | ||
| NavigationView NavigationView; |
| @@ -19,6 +17,7 @@ | |||
|
|
|||
| @Override | |||
| protected void onCreate(Bundle savedInstanceState) { | |||
|
|
|||
There was a problem hiding this comment.
I dont see any relevant change in this file. Please remove this from commit
|
|
||
| private MaterialSearchView mMaterialSearchView; | ||
|
|
||
| // private MaterialSearchView MaterialSearchView; |
| @@ -72,8 +73,11 @@ | |||
| LottieAnimationView animationView; | |||
| @BindView(R.id.cities_list) | |||
| ListView lv; | |||
| @BindView(R.id.search_view) | |||
| MaterialSearchView MaterialSearchView; | |||
There was a problem hiding this comment.
change for all places - shouldnt start with capital letter
| setSupportActionBar(toolbar); | ||
|
|
||
| ButterKnife.bind(this); | ||
|
|
||
| mHandler = new Handler(Looper.getMainLooper()); | ||
| mMap = findViewById(R.id.map); | ||
| // mMap = findViewById(R.id.map); |
| @@ -119,7 +119,7 @@ public boolean onCreateOptionsMenu(Menu menu) { | |||
|
|
|||
| public void createCode() { | |||
|
|
|||
| ImageView qrCodeView = findViewById(R.id.im); | |||
| @@ -102,4 +102,4 @@ private void onItemAutocompleteItemSelected() { | |||
| this.setSelectedText(TimeZone.getTimeZone(this.mAutoCompleteTextViewTimezone.getText().toString())); | |||
| } | |||
|
|
|||
| } | |||
| } | |||
| mAnalogHour = findViewById(R.id.hour); | ||
| mAnalogMinute = findViewById(R.id.minute); | ||
| mAnalogSecond = findViewById(R.id.second); | ||
| // |
| @BindView(R.id.minute) | ||
| AppCompatImageView AnalogMinute; | ||
| @BindView(R.id.second) | ||
| AppCompatImageView AnalogSecond; |
There was a problem hiding this comment.
no variable name should start with capital letter
|
Closing this due to inactivity. @hafiz703 reopen this if you address the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed most implementations of findviewById to @BindView in activities except those in ViewGroups / Fragments.
Fixes #780
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: