Missing listen feature added #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swati4star
requested changes
May 19, 2019
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
remove .idea folder from commit
| @@ -13,6 +14,8 @@ android: | |||
| - extra-google-m2repository | |||
| licenses: | |||
| - '.+' | |||
| before_install: | |||
| - chmod +x gradlew | |||
There was a problem hiding this comment.
are these changes required? If so, why?
There was a problem hiding this comment.
The Travis was failing so I referred to a post and made changes to solve but still the problem was nort solved.
| private AudioManager mAudioManager; | ||
|
|
||
| /** | ||
| * This listener gets triggered when the {@link MediaPlayer} has completed |
There was a problem hiding this comment.
ok I will do that
I tried with removing the whole functionality but that did not work so I approached in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The audio clip was not playing while the data was fetched from the wiki pages. Now the audio files are added that will play the audio file when the user opts for the pronunciation of the word by clicking on
listenFixes #569
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: