Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes should always advertise after seeing a new epoch #216

Open
ghjm opened this issue May 1, 2020 · 0 comments
Open

Nodes should always advertise after seeing a new epoch #216

ghjm opened this issue May 1, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@ghjm
Copy link
Contributor

ghjm commented May 1, 2020

Currently, nodes don't send route advertisements if nothing has changed in the connection table they would be sending, to avoid unnecessary traffic. However, this means that under certain circumstances, when a new (non-ephemeral) node comes on-line that is reusing the same node-id as a previously seen node, the new node can fail to receive information about other non-directly-connected nodes on the mesh.

To fix this, when a node receives a routing advertisement broadcast from an already-known node and the epoch is different, it should note this fact and not suppress its own subsequent advertisement.

(Making an issue for this so I don't forget about it.)

@ghjm ghjm added the bug Something isn't working label May 1, 2020
@matburt matburt added this to the 1.0 Release milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants