Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of feedback for PR # 349 #352

Closed
tecimovic opened this issue Dec 13, 2021 · 0 comments
Closed

Collection of feedback for PR # 349 #352

tecimovic opened this issue Dec 13, 2021 · 0 comments

Comments

@tecimovic
Copy link
Collaborator

This is the list of things that we will have to address before we can merge in the pr:
#349
I'll list them one by one in the order I encounter them...

0.) As soon as the app comes up, I see this:
image
It attracts my attention. What is it? I click it. I get "DEV TOOLS". This is too distracting. We can't have this red triangle glaringly inviting everyone to dev tools.
Also: once I do get dev tools, how do I get rid of them?
Personally I would not even mind if dev tools become a completely separate window.... I dunno. What do you think?

1.) I click 'Alt'. I get menu. I go to "Help -> About". A the bottom-right corner of the about, I see:
image
Ehm..... I can actually click it and a lot of very weird things happen from there on.... Please fix this.\

2.) This thing:
image
We should not use toggle for this. We should instead use a twistie, like these:
image
These are standardly used in the app to collapse/uncollapse a piece of UI.

3.) About:
image
No. This is NOT a preference page. Note that the preferences are a list of pages and we will add more. This is the "About dialog". Apart from the fact that I can still get it via Help -> About, this should work differently.

  • help->about menu should simply send a renderer API "about" request to the app.
  • there should be an HTML menu element "About". I think it should create a 60% transparent overlay on top of the whole app, with the About picture centered in the middle or something.

It's just weird that "About" became a preference page.

4.) Weird jumps in the attribute table:
I was testing validation... I see this..

  • Go to some attribute list screen, like this:
    image
  • Select some int "Default" field and type some nonsense, like "blah". You get to this:
    image

As you do this, notice how the screen "jumps"? The red warning didn't just appear, but the whole table shifted, as if the columns have gotten relaid out, and resized. Can we avoid this jump? It's very visually distracting.

5.) I tried to be exactly the same thing as under 4 for "Attribute reporting" tab. I went to "Attribute reporting", and tried to change the "Reportable Change" to some nonsense by typing "blah" there.
Completely different experience. Didn't show any warning, nothing happens. Can you make this experience the same as experience under point 4, with the red warning showing up and NO weird jumps.

6.) After fidgeting with the "Global options..." toggle after clicking that weird red triangle and clicking around some more, I tried "PREVIEW". Preview controls are lost under some other layout. See:
image

I have no idea how to get back to that top header of preview.

I also tried to just click "PREVIEW" right out of the box and it didn't show me anything useful either. As if the top bar is perpetually hidden behind something....
Screenshot of a freshly executed npm run zap, after I click "PREVIEW":
image

Mehradml added a commit to Mehradml/zap that referenced this issue Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant