Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int16S limit checks error #208

Closed
chrisbeach59 opened this issue Aug 16, 2021 · 2 comments · Fixed by #399
Closed

int16S limit checks error #208

chrisbeach59 opened this issue Aug 16, 2021 · 2 comments · Fixed by #399

Comments

@chrisbeach59
Copy link

When setting any of the thermostat setpoint limits (int16s) a warning is always generated for value being out of range. Correct code is generated though.
zap_int16s

@tecimovic
Copy link
Collaborator

This seems completely broken...

I go to Temperature Measurement, which has int16s:
image

I observe the following:
1.) I can type a number 13 into one of the INT16S fields, and they don't save at all.
2.) The moment I get to that page, I see exceptions:

⇝ (node:2188796) UnhandledPromiseRejectionWarning: ReferenceError: isValidSignedNumberString is not defined
    at validateSpecificAttribute (/home/timotej/git/zap/src-electron/validation/validation.js:79:7)
    at Object.validateAttribute (/home/timotej/git/zap/src-electron/validation/validation.js:38:10)
    at /home/timotej/git/zap/src-electron/rest/user-data.js:210:26
(Use `electron --trace-warnings ...` to show where the warning was created)
⇝ (node:2188796) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:2188796) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@tecimovic
Copy link
Collaborator

I have no idea what's going on, but there is no validation happening, numbers are not saving and exceptions are coming from back-end.
Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants