Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] ensure responses are enabled for any enabled commands #1165

Open
andy31415 opened this issue Oct 6, 2023 · 0 comments
Open
Labels
matter Important to Matter SDK

Comments

@andy31415
Copy link
Contributor

in project-chip/connectedhomeip#29509 we have found that one could configure commands such that the request for a command is code-generated, but not the response.

This seems odd:

  • for servers, if you can process a request, being able to reply is mandatory
  • for clients, if you can send a command presumably you have to be able to decode the reply

It seems reasonable to at a minimum show a large WARNING if such a mismatch happens and I believe it would be best to enforce that if a command is enabled, its response="..." is also enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matter Important to Matter SDK
Projects
Development

No branches or pull requests

2 participants