Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-SC-5.3] Question about the DSIZ flag in test case TC-SC-5.3 step 6 #62

Closed
lion6420 opened this issue Nov 17, 2023 · 4 comments
Closed
Assignees

Comments

@lion6420
Copy link

Description:

Step 6 checks if the DSIZ flag is set to group. The expected value mentioned in step 6 is 0x4 (0100).

Verify the DSIZ flag is set to Group On TH(Reference app) log:
          (Here in below log the value recived is 0X04 = 0100 (decimal) - Here the bit 2 is enabled then DSIZ flag is set to group)

          [1686317564.742205][7679:7679] CHIP:DMG: Header Flags =
          [1686317564.742207][7679:7679] CHIP:DMG: {
          [1686317564.742212][7679:7679] CHIP:DMG:     Message (0x04) =
          [1686317564.742214][7679:7679] CHIP:DMG:     {
          [1686317564.742217][7679:7679] CHIP:DMG:         SourceNodeId = C831420E9B16886B
          [1686317564.742219][7679:7679] CHIP:DMG:     }
          [1686317564.742224][7679:7679] CHIP:DMG:     Exchange (0x03) =
          [1686317564.742226][7679:7679] CHIP:DMG:     {
          [1686317564.742228][7679:7679] CHIP:DMG:         Initiator = true
          [1686317564.742231][7679:7679] CHIP:DMG:         AckMsg = 48718950
          [1686317564.742233][7679:7679] CHIP:DMG:     }
          [1686317564.742237][7679:7679] CHIP:DMG: }

According to the spec, the DSIZ value 2 (10) is for group id present.
Therefore, my question is if the expected value result should be 0x2 (0010) or 0x6 (0110) ?
Or there is something I am missing or misunderstanding?

Yaml Reference:

TC-SC-5.3

@sumaky
Copy link

sumaky commented Nov 23, 2023

@lion6420 The expected value is 0x6 and the VS sheet is now updated correctly as below. @manjunath-grl The script has to be updated correctly as per the below changes.

@lion6420 please find the link for the VS sheet document
https://docs.google.com/spreadsheets/d/13zltSz50GRs_kidvobceEuIT8kAAHSK64ANyWcc3xQI/edit#gid=2120858180

Verify the DSIZ flag is set to Group On TH(Reference app) log:
(Here in below log the value received is 0X06 = 0110 (binary) - Here the S Flag (1 bit, position 2) is enabled as SourceNodeID is present and DISZ has a value 2(10) as the Destination Node ID field is present as a 16-bit Group
[1700720496.175477][40754:40754] CHIP:DMG: Header Flags =
[1700720496.175481][40754:40754] CHIP:DMG: {
[1700720496.175485][40754:40754] CHIP:DMG: Security (0x01) =
[1700720496.175489][40754:40754] CHIP:DMG: {
[1700720496.175492][40754:40754] CHIP:DMG: }
[1700720496.175497][40754:40754] CHIP:DMG: Message (0x06) =
[1700720496.175500][40754:40754] CHIP:DMG: {
[1700720496.175505][40754:40754] CHIP:DMG: SourceNodeId = 000000000001B669
[1700720496.175508][40754:40754] CHIP:DMG: DestinationGroupIdPresent = 0x0103
[1700720496.175512][40754:40754] CHIP:DMG: }
[1700720496.175519][40754:40754] CHIP:DMG: Exchange (0x01) =
[1700720496.175523][40754:40754] CHIP:DMG: {
[1700720496.175525][40754:40754] CHIP:DMG: Initiator = true
[1700720496.175529][40754:40754] CHIP:DMG: }

@lion6420
Copy link
Author

@sumaky Thanks for your reply !
Should I close this issue?

@sumaky
Copy link

sumaky commented Nov 23, 2023

@lion6420 We can wait till the script issue is fixed by @manjunath-grl . Once done you could review and close the issue. Thanks.

@manjunath-grl manjunath-grl self-assigned this Nov 23, 2023
@manjunath-grl
Copy link
Collaborator

@lion6420 fixed in PR 30575 please verify it and close the ticket.
CC @sumaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants