Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-IDM-1.3] The command has to be revised as per the chip-repl. #124

Closed
Survensa opened this issue Jan 31, 2024 · 5 comments · Fixed by project-chip/connectedhomeip#31796
Assignees

Comments

@Survensa
Copy link

Summary Title:

The commands mentioned in the YAML seems to be not working, which has to be revised. 

Description:

IDM_1_3.mp4

Steps to reproduce:

  • Build the environment : `scripts/run_in_build_env.sh './scripts/build_python.sh --install_virtual_env out/venv -d true'`
    
  • Open Repl shell : `chip-repl`
    
  • Bring up the sample app the other side
    
  • Provide the commissioning command in repl shell : `devCtrl.CommissionOnNetwork(0x12344321, 20202021)`
    
  • Try running the following command in the TC_IDM_1.3.yaml  
    

Additional Info:

Not sure either the command in yaml has to be modified or SDK has to be modified. 
@Survensa
Copy link
Author

@tehampson Please look into this issue.

@tehampson
Copy link

Thanks for reporting the issue project-chip/connectedhomeip#31796 will fix the issue.

The 3 fixes are:

  • The issue with the batch command is that I missing a ) at the very end. This was likely a copy paste error on my part, Sorry
  • As you already discovered SendCommands needs to that that final s removed. It should be SendCommand
  • name Cluster not defined. If you do import chip.clusters as Clusters after starting chip-repl you should have no more issues. To make the example command more resilient I changed the all Clusters. to chip.clusters, that way the import is no longer needed

If you'd like to give the updated yaml a try please let me know if you run into any other issues

@tehampson
Copy link

I cannot mark this as fixed, but it should be fixed now with the latest instructions

@tehampson
Copy link

@Survensa can you please confirm that the latest update that includes project-chip/connectedhomeip#31796 does fix this issue for you. If so please close the issue

@Survensa
Copy link
Author

Survensa commented Feb 6, 2024

Issue fixed hence closing the issue

@Survensa Survensa closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants