Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandSender and CommandHandler reserves space for Finalize to succeed #31077

Merged
merged 6 commits into from
Jan 3, 2024
Merged

CommandSender and CommandHandler reserves space for Finalize to succeed #31077

merged 6 commits into from
Jan 3, 2024

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Dec 18, 2023 •
edited
Loading

Problem:

  • Finalize can fail if there is not enough space in the buffer to end the IM messages

Solution:

  • Reserve enough space for the end of the message

Now that #30714 has landed, I feel more comfortable about setting precedent in using ReserveBuffer

Tests:

  • Added unit test to make sure that GetSizeToEnd... matches how much we end up using in EndOf... when using the Init... that performs reservation in TLVWriter for the various IM structures. This will be ongoing in CI to ensure they match

@tehampson tehampson mentioned this pull request Dec 18, 2023
Open
53 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited
Loading

PR #31077: Size comparison from 9310a37 to 1ddb9fe

Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9310a37 1ddb9fe change % change
bl602 lighting-app bl602 (read/write) 1417794 1418154 360 0.0
.text 1085664 1086020 356 0.0
bl602+mfd (read/write) 1432522 1432882 360 0.0
.text 1101288 1101644 356 0.0
bl602+rpc (read/write) 1465578 1465938 360 0.0
.text 1117408 1117764 356 0.0
bl702 lighting-app bl702 (read/write) 1182811 1183167 356 0.0
.text 955366 955722 356 0.0
bl702+mfd (read/write) 1193943 1194299 356 0.0
.text 967430 967786 356 0.0
bl702+rpc (read/write) 1274823 1275179 356 0.0
.text 1030428 1030784 356 0.0
bl706-eth (read/write) 1002437 1002793 356 0.0
.text 748262 748618 356 0.0
bl706-wifi (read/write) 1240574 1240974 400 0.0
.text 975558 975958 400 0.0
bl702l lighting-app bl702l (read/write) 1152516 1152872 356 0.0
.text 948492 948848 356 0.0
bl702l+mfd (read/write) 1163968 1164836 868 0.1
.text 960868 961224 356 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771688 771888 200 0.0
.text 681884 682084 200 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787792 787992 200 0.0
.text 703736 703936 200 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776016 776208 192 0.0
.text 665360 665552 192 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728632 728824 192 0.0
.text 643252 643444 192 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714168 714360 192 0.0
.text 632956 633148 192 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566994 567090 96 0.0
.text 480932 481028 96 0.0
lock CC3235SF_LAUNCHXL (read only) 620322 620418 96 0.0
.text 512388 512484 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561007 561199 192 0.0
.app_xip_area 451257 451449 192 0.0
lock cyw930739m2evb_01 (read/write) 543231 543423 192 0.0
.app_xip_area 428745 428937 192 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561967 562159 192 0.0
.app_xip_area 453673 453865 192 0.0
switch cyw930739m2evb_01 (read/write) 557399 557599 200 0.0
.app_xip_area 445881 446081 200 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017020 1017212 192 0.0
.text 841712 841904 192 0.0
BRD4187C (read/write) 1100956 1101148 192 0.0
.text 901436 901628 192 0.0
lock-app BRD4161A+wf200 (read/write) 1114832 1115016 184 0.0
.text 923284 923468 184 0.0
window-app BRD4187C (read/write) 1135744 1135936 192 0.0
.text 964320 964512 192 0.0
esp32 all-clusters-app c3devkit (read only) 1137734 1137946 212 0.0
.flash.text 1137734 1137946 212 0.0
m5stack (read only) 1182731 1182999 268 0.0
.flash.text 1177347 1177615 268 0.0
k32w contact k32w0+release (read only) 605192 605384 192 0.0
.text 604656 604848 192 0.0
k32w1+release (read/write) 690656 690856 200 0.0
.text 576864 577064 200 0.0
light k32w0+release (read only) 594880 595088 208 0.0
.text 594344 594552 208 0.0
k32w1+release (read/write) 782468 782660 192 0.0
.text 659808 660000 192 0.0
lock k32w0+release (read only) 576296 576392 96 0.0
.text 575760 575856 96 0.0
linux air-purifier-app debug (read only) 2526309 2526885 576 0.0
.rodata 179336 179400 64 0.0
.text 2171493 2172005 512 0.0
all-clusters-app debug (read only) 5413841 5414945 1104 0.0
.rodata 312124 312188 64 0.0
.text 4691923 4692963 1040 0.0
all-clusters-minimal-app debug (read only) 4953377 4954481 1104 0.0
.rodata 272845 272909 64 0.0
.text 4447987 4449027 1040 0.0
bridge-app debug (read only) 4417105 4417617 512 0.0
.text 3979299 3979811 512 0.0
chip-tool debug (read only) 11687081 11687961 880 0.0
.rodata 424681 424745 64 0.0
.text 10572515 10573331 816 0.0
chip-tool-ipv6only arm64 (read only) 11414256 11415008 752 0.0
.text 10201256 10202008 752 0.0
lighting-app debug+rpc+ui (read only) 5302921 5303513 592 0.0
.rodata 340372 340436 64 0.0
.text 4717683 4718211 528 0.0
lock-app debug (read only) 4502169 4502745 576 0.0
.rodata 247029 247093 64 0.0
.text 4045027 4045539 512 0.0
ota-provider-app debug (read only) 4166297 4166841 544 0.0
.rodata 201301 201333 32 0.0
.text 3773043 3773555 512 0.0
ota-requestor-app debug (read only) 4255785 4256889 1104 0.0
.rodata 205141 205205 64 0.0
.text 3854291 3855331 1040 0.0
shell debug (read only) 2788697 2789561 864 0.0
.rodata 181920 181984 64 0.0
.text 2435682 2436482 800 0.0
thermostat-no-ble arm64 (read only) 4405664 4406416 752 0.0
.text 3902888 3903640 752 0.0
tv-app debug (read only) 5386385 5387489 1104 0.0
.rodata 272981 273045 64 0.0
.text 4875475 4876515 1040 0.0
tv-casting-app debug (read only) 9566521 9567625 1104 0.0
.rodata 362888 362952 64 0.0
.text 8739779 8740819 1040 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2525992 2526120 128 0.0
.text 1488676 1488804 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1067684 1067876 192 0.0
text 785324 785520 196 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1193776 1193984 208 0.0
text 782692 782888 196 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1046696 1046888 192 0.0
text 770272 770468 196 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1750980 1751124 144 0.0
.text 1545116 1545260 144 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1705940 1706100 160 0.0
.text 1502124 1502284 160 0.0
light cy8ckit_062s2_43012 (read/write) 1630924 1631004 80 0.0
.text 1433796 1433876 80 0.0
lock cy8ckit_062s2_43012 (read/write) 1657812 1657908 96 0.0
.text 1433564 1433660 96 0.0
qpg lighting-app qpg6105+debug (read/write) 1116572 1116772 200 0.0
.text 628948 629148 200 0.0
lock-app qpg6105+debug (read/write) 1080564 1080764 200 0.0
.text 592944 593144 200 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 821354 821458 104 0.0
text 613712 613816 104 0.0
all-clusters-app tlsr9518adk80d (read/write) 1086576 1086792 216 0.0
text 767102 767314 212 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1084012 1084220 208 0.0
text 753344 753556 212 0.0
bridge-app tlsr9518adk80d (read/write) 934644 934748 104 0.0
text 646762 646866 104 0.0
contact-sensor-app tlsr9528a_retention (read/write) 821590 821694 104 0.0
text 614082 614186 104 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 978676 978892 216 0.0
text 694172 694384 212 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1092992 1093208 216 0.0
text 769654 769866 212 0.0
lock-app-dfu tlsr9528a (read/write) 965308 965412 104 0.0
text 647848 647952 104 0.0
ota-requestor-app tlsr9518adk80d (read/write) 948320 948536 216 0.0
text 662870 663082 212 0.0
pump-app tlsr9528a (read/write) 880388 880556 168 0.0
text 622092 622258 166 0.0
pump-controller-app tlsr9518adk80d (read/write) 821000 821168 168 0.0
text 588968 589134 166 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 823326 823430 104 0.0
text 616826 616930 104 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 878093 878301 208 0.0
text 630708 630920 212 0.0
thermostat tlsr9518adk80d (read/write) 845372 845540 168 0.0
text 607434 607600 166 0.0
window-covering tlsr9518adk80d (read/write) 839648 839752 104 0.0
text 601468 601572 104 0.0
Decreases (2 builds for linux)
platform target config section 9310a37 1ddb9fe change % change
linux chip-tool-ipv6only arm64 (read/write) 572440 571688 -752 -0.1
thermostat-no-ble arm64 (read/write) 244832 244080 -752 -0.3
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9310a37 1ddb9fe change % change
bl602 lighting-app bl602 (read/write) 1417794 1418154 360 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156912 156912 0 0.0
.text 1085664 1086020 356 0.0
bl602+mfd (read/write) 1432522 1432882 360 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155872 155872 0 0.0
.text 1101288 1101644 356 0.0
bl602+rpc (read/write) 1465578 1465938 360 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164536 164536 0 0.0
.text 1117408 1117764 356 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182811 1183167 356 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106288 106288 0 0.0
.text 955366 955722 356 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1193943 1194299 356 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105228 105228 0 0.0
.text 967430 967786 356 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274823 1275179 356 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121708 121708 0 0.0
.text 1030428 1030784 356 0.0
bl706-eth (read/write) 1002437 1002793 356 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99620 99620 0 0.0
.text 748262 748618 356 0.0
bl706-wifi (read/write) 1240574 1240974 400 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120600 120600 0 0.0
.text 975558 975958 400 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152516 1152872 356 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100292 100292 0 0.0
.text 948492 948848 356 0.0
bl702l+mfd (read/write) 1163968 1164836 868 0.1
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99232 99232 0 0.0
.text 960868 961224 356 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771688 771888 200 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89536 89536 0 0.0
.text 681884 682084 200 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787792 787992 200 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83792 83792 0 0.0
.text 703736 703936 200 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776016 776208 192 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110392 110392 0 0.0
.text 665360 665552 192 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728632 728824 192 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85112 85112 0 0.0
.text 643252 643444 192 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714168 714360 192 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80944 80944 0 0.0
.text 632956 633148 192 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566994 567090 96 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83938 83938 0 0.0
.text 480932 481028 96 0.0
lock CC3235SF_LAUNCHXL (read only) 620322 620418 96 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105810 105810 0 0.0
.text 512388 512484 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561007 561199 192 0.0
.app_xip_area 451257 451449 192 0.0
.bss 64664 64664 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543231 543423 192 0.0
.app_xip_area 428745 428937 192 0.0
.bss 69360 69360 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561967 562159 192 0.0
.app_xip_area 453673 453865 192 0.0
.bss 63280 63280 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557399 557599 200 0.0
.app_xip_area 445881 446081 200 0.0
.bss 66400 66400 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017020 1017212 192 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841712 841904 192 0.0
BRD4187C (read/write) 1100956 1101148 192 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901436 901628 192 0.0
lock-app BRD4161A+wf200 (read/write) 1114832 1115016 184 0.0
.bss 188816 188816 0 0.0
.data 2712 2712 0 0.0
.text 923284 923468 184 0.0
window-app BRD4187C (read/write) 1135744 1135936 192 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964320 964512 192 0.0
esp32 all-clusters-app c3devkit (read only) 1137734 1137946 212 0.0
(read/write) 1671524 1671524 0 0.0
.dram0.bss 72872 72872 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241792 241792 0 0.0
.flash.text 1137734 1137946 212 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182731 1182999 268 0.0
(read/write) 520716 520716 0 0.0
.dram0.bss 79520 79520 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272828 272828 0 0.0
.flash.text 1177347 1177615 268 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605192 605384 192 0.0
(read/write) 81896 81896 0 0.0
.bss 69744 69744 0 0.0
.data 2168 2168 0 0.0
.text 604656 604848 192 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690656 690856 200 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576864 577064 200 0.0
light k32w0+release (read only) 594880 595088 208 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594344 594552 208 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782468 782660 192 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659808 660000 192 0.0
lock k32w0+release (read only) 576296 576392 96 0.0
(read/write) 79376 79376 0 0.0
.bss 67296 67296 0 0.0
.data 2096 2096 0 0.0
.text 575760 575856 96 0.0
linux air-purifier-app debug (read only) 2526309 2526885 576 0.0
(read/write) 127240 127240 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72824 72824 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179336 179400 64 0.0
.text 2171493 2172005 512 0.0
all-clusters-app debug (read only) 5413841 5414945 1104 0.0
(read/write) 455080 455080 0 0.0
.bss 131632 131632 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 312360 312360 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1264 1264 0 0.0
.rodata 312124 312188 64 0.0
.text 4691923 4692963 1040 0.0
all-clusters-minimal-app debug (read only) 4953377 4954481 1104 0.0
(read/write) 234720 234720 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95960 95960 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272845 272909 64 0.0
.text 4447987 4449027 1040 0.0
bridge-app debug (read only) 4417105 4417617 512 0.0
(read/write) 215960 215960 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85280 85280 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219157 219157 0 0.0
.text 3979299 3979811 512 0.0
chip-tool debug (read only) 11687081 11687961 880 0.0
(read/write) 504048 504048 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 397616 397616 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 424681 424745 64 0.0
.text 10572515 10573331 816 0.0
chip-tool-ipv6only arm64 (read only) 11414256 11415008 752 0.0
(read/write) 572440 571688 -752 -0.1
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436456 436456 0 0.0
.dynamic 512 512 0 0.0
.got 19816 19816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 345048 345048 0 0.0
.text 10201256 10202008 752 0.0
lighting-app debug+rpc+ui (read only) 5302921 5303513 592 0.0
(read/write) 225032 225032 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340372 340436 64 0.0
.text 4717683 4718211 528 0.0
lock-app debug (read only) 4502169 4502745 576 0.0
(read/write) 203648 203648 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247093 64 0.0
.text 4045027 4045539 512 0.0
ota-provider-app debug (read only) 4166297 4166841 544 0.0
(read/write) 192728 192728 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69296 69296 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201333 32 0.0
.text 3773043 3773555 512 0.0
ota-requestor-app debug (read only) 4255785 4256889 1104 0.0
(read/write) 197040 197040 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205141 205205 64 0.0
.text 3854291 3855331 1040 0.0
shell debug (read only) 2788697 2789561 864 0.0
(read/write) 152272 152272 0 0.0
.bss 62312 62312 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83400 83400 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 181920 181984 64 0.0
.text 2435682 2436482 800 0.0
thermostat-no-ble arm64 (read only) 4405664 4406416 752 0.0
(read/write) 244832 244080 -752 -0.3
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102352 102352 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3902888 3903640 752 0.0
tv-app debug (read only) 5386385 5387489 1104 0.0
(read/write) 349120 349120 0 0.0
.bss 244544 244544 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92280 92280 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272981 273045 64 0.0
.text 4875475 4876515 1040 0.0
tv-casting-app debug (read only) 9566521 9567625 1104 0.0
(read/write) 338368 338368 0 0.0
.bss 156352 156352 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 172696 172696 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 362888 362952 64 0.0
.text 8739779 8740819 1040 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525992 2526120 128 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488676 1488804 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1067684 1067876 192 0.0
bss 129393 129393 0 0.0
rodata 105396 105396 0 0.0
text 785324 785520 196 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1193776 1193984 208 0.0
bss 121603 121603 0 0.0
rodata 139156 139156 0 0.0
text 782692 782888 196 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046696 1046888 192 0.0
bss 129348 129348 0 0.0
rodata 99448 99448 0 0.0
text 770272 770468 196 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835864 835864 0 0.0
(read/write) 1750980 1751124 144 0.0
.bss 195004 195004 0 0.0
.data 2472 2472 0 0.0
.text 1545116 1545260 144 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705940 1706100 160 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502124 1502284 160 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630924 1631004 80 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433796 1433876 80 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657812 1657908 96 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433564 1433660 96 0.0
qpg lighting-app qpg6105+debug (read/write) 1116572 1116772 200 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 628948 629148 200 0.0
lock-app qpg6105+debug (read/write) 1080564 1080764 200 0.0
.bss 97512 97512 0 0.0
.data 784 784 0 0.0
.text 592944 593144 200 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821354 821458 104 0.0
bss 55064 55064 0 0.0
text 613712 613816 104 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086576 1086792 216 0.0
bss 100404 100404 0 0.0
text 767102 767314 212 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1084012 1084220 208 0.0
bss 109764 109764 0 0.0
text 753344 753556 212 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934644 934748 104 0.0
bss 94272 94272 0 0.0
text 646762 646866 104 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821590 821694 104 0.0
bss 55108 55108 0 0.0
text 614082 614186 104 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978676 978892 216 0.0
bss 79092 79092 0 0.0
text 694172 694384 212 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092992 1093208 216 0.0
bss 99836 99836 0 0.0
text 769654 769866 212 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 965308 965412 104 0.0
bss 97356 97356 0 0.0
text 647848 647952 104 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948320 948536 216 0.0
bss 92380 92380 0 0.0
text 662870 663082 212 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 880388 880556 168 0.0
bss 69084 69084 0 0.0
text 622092 622258 166 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 821000 821168 168 0.0
bss 57320 57320 0 0.0
text 588968 589134 166 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705600 705600 0 0.0
bss 73588 73588 0 0.0
text 462094 462094 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823326 823430 104 0.0
bss 55244 55244 0 0.0
text 616826 616930 104 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878093 878301 208 0.0
bss 60796 60796 0 0.0
text 630708 630920 212 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845372 845540 168 0.0
bss 57616 57616 0 0.0
text 607434 607600 166 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839648 839752 104 0.0
bss 57968 57968 0 0.0
text 601468 601572 104 0.0

bzbarsky-apple
bzbarsky-apple requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the CommandHandler bits are right...

src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/InvokeRequestMessage.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/InvokeRequestMessage.h Outdated Show resolved Hide resolved
src/app/MessageDef/InvokeRequests.cpp Show resolved Hide resolved
src/app/MessageDef/InvokeResponseIBs.h Outdated Show resolved Hide resolved
src/app/MessageDef/InvokeResponseMessage.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/InvokeResponseMessage.h Outdated Show resolved Hide resolved
src/app/tests/TestMessageDef.cpp Outdated Show resolved Hide resolved
src/app/tests/TestMessageDef.cpp Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Jan 2, 2024
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Jan 3, 2024
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
@mergify mergify bot merged commit d2de5d5 into project-chip:master Jan 3, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @bzbarsky-apple @jmartinez-silabs @restyled-commits