Implement initial Kotlin generator #30009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #30009: Size comparison from 4823e34 to 059e763 Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #30009: Size comparison from 5a284f0 to ee93936 Full report (10 builds for cc32xx, linux, mbed, nrfconnect, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #30009: Size comparison from 38e459b to d9a6b91 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Oct 25, 2023
This is not the final version, current cluster APIs does not have any common function to share, we also don't need the chipClusterPtr and devicePtr if we switch to use generic IM API. Will add Super Class later if there is something we could share among all Cluster APIs |
andy31415
reviewed
Oct 26, 2023
| @@ -155,6 +155,7 @@ style: | |||
| - "**/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/provisioning/EnterNetworkFragment.kt" | |||
| - "**/examples/java-matter-controller/java/src/com/matter/controller/commands/common/MatterCommand.kt" | |||
| - "**/src/controller/java/src/matter/onboardingpayload/Base38.kt" | |||
| - "**/src/controller/java/generated/java/**/*" | |||
There was a problem hiding this comment.
should we have kotlin as prefix instead of java?
andy31415
reviewed
Oct 26, 2023
| @@ -246,6 +247,9 @@ naming: | |||
| excludes: | |||
| - "**/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/HistoryCommandAdapter.kt" | |||
| - "**/src/controller/java/generated/java/**/*" | |||
| FunctionParameterNaming: | |||
| excludes: | |||
| - "**/src/controller/java/generated/java/**/*" | |||
There was a problem hiding this comment.
Some doc comments about why this is required for generated code would be nice.
Here is where a separate kotlin directory would be nice too, so we do not inherit leniency from other places - we should try to make even the generated kotlin code look "nice" in as much as possible.
andy31415
reviewed
Oct 26, 2023
| {%- if interfaceName not in already_handled_attribute %} | ||
| interface {{interfaceName}} { | ||
| fun onSuccess(value: {{encode_value(cluster, encodable, 0)}}) | ||
| fun onError(ex: Exception) |
There was a problem hiding this comment.
onError and onSubscriptionEstablished are always the same. Would it make sense to have a common base interface for them (so that a generic error handler could be written for anything) or would that break some ABI that already exists?
Same for common functions above (e.g. I see on error in other places too)
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the preliminary implementation of the Kotlin generator. It produces the Kotlin cluster API in a manner compatible with the existing Java Cluster API. This enables us to experiment with using TLV-based generic Im APIs.