From 3e598dcf161dd414a3a45efa221bc90b6539836e Mon Sep 17 00:00:00 2001 From: William Hicklin Date: Thu, 19 Oct 2023 14:13:55 +0100 Subject: [PATCH 1/3] Removed the StartUpMode attribute from the RVC ModeBase clusters in chef's RVC device. --- ...ode_roboticvacuumcleaner_1807ff0c49.matter | 4 --- ...otnode_roboticvacuumcleaner_1807ff0c49.zap | 36 ++----------------- 2 files changed, 3 insertions(+), 37 deletions(-) diff --git a/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter b/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter index 789188da2eeeb9..82d3352f402d7d 100644 --- a/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter +++ b/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter @@ -1040,7 +1040,6 @@ server cluster RvcRunMode = 84 { readonly attribute ModeOptionStruct supportedModes[] = 0; readonly attribute int8u currentMode = 1; - attribute nullable int8u startUpMode = 2; attribute nullable int8u onMode = 3; readonly attribute command_id generatedCommandList[] = 65528; readonly attribute command_id acceptedCommandList[] = 65529; @@ -1090,7 +1089,6 @@ server cluster RvcCleanMode = 85 { readonly attribute ModeOptionStruct supportedModes[] = 0; readonly attribute int8u currentMode = 1; - attribute nullable int8u startUpMode = 2; attribute nullable int8u onMode = 3; readonly attribute command_id generatedCommandList[] = 65528; readonly attribute command_id acceptedCommandList[] = 65529; @@ -1426,7 +1424,6 @@ endpoint 1 { server cluster RvcRunMode { callback attribute supportedModes default = 0; callback attribute currentMode default = 0; - callback attribute startUpMode default = 0; callback attribute onMode default = 0; callback attribute generatedCommandList; callback attribute acceptedCommandList; @@ -1442,7 +1439,6 @@ endpoint 1 { server cluster RvcCleanMode { callback attribute supportedModes default = 0; callback attribute currentMode default = 0; - callback attribute startUpMode default = 0; callback attribute onMode default = 0; callback attribute generatedCommandList; callback attribute acceptedCommandList; diff --git a/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap b/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap index 5c1ac4df4af665..59784bfba8e5eb 100644 --- a/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap +++ b/examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap @@ -2266,6 +2266,7 @@ "define": "SCENES_CLUSTER", "side": "server", "enabled": 1, + "apiMaturity": "provisional", "commands": [ { "name": "AddScene", @@ -2811,22 +2812,6 @@ "maxInterval": 65534, "reportableChange": 0 }, - { - "name": "StartUpMode", - "code": 2, - "mfgCode": null, - "side": "server", - "type": "int8u", - "included": 1, - "storageOption": "External", - "singleton": 0, - "bounded": 0, - "defaultValue": "0", - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, { "name": "OnMode", "code": 3, @@ -2999,22 +2984,6 @@ "maxInterval": 65534, "reportableChange": 0 }, - { - "name": "StartUpMode", - "code": 2, - "mfgCode": null, - "side": "server", - "type": "int8u", - "included": 1, - "storageOption": "External", - "singleton": 0, - "bounded": 0, - "defaultValue": "0", - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, { "name": "OnMode", "code": 3, @@ -3391,5 +3360,6 @@ "endpointId": 1, "networkId": 0 } - ] + ], + "log": [] } \ No newline at end of file From f7e9a6d57deed15363b11c53e53069a72e17c166 Mon Sep 17 00:00:00 2001 From: William Hicklin Date: Thu, 19 Oct 2023 14:51:39 +0100 Subject: [PATCH 2/3] Reverted the changes made in PR 29248 following the spec change in PR 7576. --- examples/rvc-app/README.md | 6 +----- .../pics/RVC Clean Mode Cluster Test Plan.xml | 2 +- .../rvc-common/pics/RVC_App_Test_Plan.txt | 2 +- examples/rvc-app/rvc-common/rvc-app.matter | 2 -- examples/rvc-app/rvc-common/rvc-app.zap | 19 ++----------------- 5 files changed, 5 insertions(+), 26 deletions(-) diff --git a/examples/rvc-app/README.md b/examples/rvc-app/README.md index cd8bc0461fcbc1..f1b87ca995a934 100644 --- a/examples/rvc-app/README.md +++ b/examples/rvc-app/README.md @@ -69,11 +69,7 @@ transition to mode 2", set the `RvcRunMode` to 0. #### TC 3.2 -PIXIT: `PIXIT_ENDPOINT:1` -Example command: -`./scripts/tests/run_python_test.py --script src/python_testing/TC_RVCCLEANM_3_2.py --script-args "--storage-path admin_storage.json --PICS examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt --int-arg PIXIT_ENDPOINT:1"` - -When asked "Physically power cycle the device", do so. +This is not applicable because this RVC device does not support the `StartUpMode` attribute. ### RVC Run Mode cluster diff --git a/examples/rvc-app/rvc-common/pics/RVC Clean Mode Cluster Test Plan.xml b/examples/rvc-app/rvc-common/pics/RVC Clean Mode Cluster Test Plan.xml index c5776d9553a9bb..ce0ddaa38b5307 100644 --- a/examples/rvc-app/rvc-common/pics/RVC Clean Mode Cluster Test Plan.xml +++ b/examples/rvc-app/rvc-common/pics/RVC Clean Mode Cluster Test Plan.xml @@ -61,7 +61,7 @@ Draft Does the device implement the StartUpMode attribute? 89.2.2. Attributes - allclusters.html[pdf] O - true + false RVCCLEANM.S.A0003 diff --git a/examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt b/examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt index c4c5ef7586bdce..d0c8529a83d2e0 100644 --- a/examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt +++ b/examples/rvc-app/rvc-common/pics/RVC_App_Test_Plan.txt @@ -1,7 +1,7 @@ RVCCLEANM.S=1 RVCCLEANM.S.A0000=1 RVCCLEANM.S.A0001=1 -RVCCLEANM.S.A0002=1 +RVCCLEANM.S.A0002=0 RVCCLEANM.S.A0003=0 RVCCLEANM.S.C01.Tx=1 RVCCLEANM.S.C00.Rsp=1 diff --git a/examples/rvc-app/rvc-common/rvc-app.matter b/examples/rvc-app/rvc-common/rvc-app.matter index 1c944bf51fc41f..b7cc998e415547 100644 --- a/examples/rvc-app/rvc-common/rvc-app.matter +++ b/examples/rvc-app/rvc-common/rvc-app.matter @@ -897,7 +897,6 @@ server cluster RvcCleanMode = 85 { readonly attribute ModeOptionStruct supportedModes[] = 0; readonly attribute int8u currentMode = 1; - attribute nullable int8u startUpMode = 2; readonly attribute command_id generatedCommandList[] = 65528; readonly attribute command_id acceptedCommandList[] = 65529; readonly attribute event_id eventList[] = 65530; @@ -1194,7 +1193,6 @@ endpoint 1 { server cluster RvcCleanMode { callback attribute supportedModes; callback attribute currentMode; - callback attribute startUpMode; callback attribute generatedCommandList; callback attribute acceptedCommandList; callback attribute eventList; diff --git a/examples/rvc-app/rvc-common/rvc-app.zap b/examples/rvc-app/rvc-common/rvc-app.zap index 9c0844f84190aa..79dfa8bd75c3db 100644 --- a/examples/rvc-app/rvc-common/rvc-app.zap +++ b/examples/rvc-app/rvc-common/rvc-app.zap @@ -2439,22 +2439,6 @@ "maxInterval": 65534, "reportableChange": 0 }, - { - "name": "StartUpMode", - "code": 2, - "mfgCode": null, - "side": "server", - "type": "int8u", - "included": 1, - "storageOption": "External", - "singleton": 0, - "bounded": 0, - "defaultValue": null, - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, { "name": "GeneratedCommandList", "code": 65528, @@ -2799,5 +2783,6 @@ "endpointId": 1, "networkId": 0 } - ] + ], + "log": [] } \ No newline at end of file From 138f01a1232fc38bfe050012b41c42688f4c7d6d Mon Sep 17 00:00:00 2001 From: "Restyled.io" Date: Thu, 19 Oct 2023 14:17:28 +0000 Subject: [PATCH 3/3] Restyled by prettier-markdown --- examples/rvc-app/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/rvc-app/README.md b/examples/rvc-app/README.md index f1b87ca995a934..fa723f24d35712 100644 --- a/examples/rvc-app/README.md +++ b/examples/rvc-app/README.md @@ -69,7 +69,8 @@ transition to mode 2", set the `RvcRunMode` to 0. #### TC 3.2 -This is not applicable because this RVC device does not support the `StartUpMode` attribute. +This is not applicable because this RVC device does not support the +`StartUpMode` attribute. ### RVC Run Mode cluster