-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a non-chunked attribute for non-chunking tests in TestReadInteraction. #27126
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:subscription-test-fix
Jun 7, 2023
Merged
Use a non-chunked attribute for non-chunking tests in TestReadInteraction. #27126
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:subscription-test-fix
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Jun 7, 2023
jmartinez-silabs
approved these changes
Jun 7, 2023
…tion. We were using an attribute that led to multiple reports, in a test that only cares about whether a report is delivered at all. There's no reason to do that, and it can lead to some timing-related failures if we don't spin the event loop long enough to get all the reports.
bzbarsky-apple
force-pushed
the
subscription-test-fix
branch
from
June 7, 2023 14:59
6c524be
to
e393666
Compare
Closed
PR #27126: Size comparison from f6c1a89 to e393666 Increases (9 builds for bl702, cyw30739, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jun 7, 2023
tcarmelveilleux
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using an attribute that led to multiple reports, in a test that only cares about whether a report is delivered at all. There's no reason to do that, and it can lead to some timing-related failures if we don't spin the event loop long enough to get all the reports.