Remove no-op esp32 config #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
rwalker-apple and
saurabhst
as code owners
BroderickCarlin
approved these changes
Sep 16, 2020
This doesn't do anything as configs on a target don't apply to its dependencies; information flows exclusively the other way. The target_defines variable can be used for this, but there's no code in libCHIP that uses BUILD_RELEASE anyway (in any case, we should probably just use !defined(NDEBUG) as that aligns with the C standard).
mspang
force-pushed
the
for-chip/noop-config
branch
from
6a8a48d to
5c51153
Compare
andy31415
approved these changes
Sep 16, 2020
bzbarsky-apple
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do anything as configs on a target don't apply to its
dependencies; information flows exclusively the other way. The
target_defines argument can be used for this, but there's no code in
libCHIP that uses BUILD_RELEASE anyway (in any case, we should probably
just use !defined(NDEBUG) as that aligns with the C standard).
Problem
No-op code in config/esp32.
Summary of Changes
Remove it.