From fbcc02ba9432c5d0f8a5364e7852418ed1210d62 Mon Sep 17 00:00:00 2001 From: Rohit Jadhav Date: Tue, 28 Mar 2023 10:49:21 +0530 Subject: [PATCH 1/5] [ESP32] Set default apply update action to proceed --- examples/ota-provider-app/esp32/main/main.cpp | 1 + examples/ota-requestor-app/esp32/README.md | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ota-provider-app/esp32/main/main.cpp b/examples/ota-provider-app/esp32/main/main.cpp index d016149f5b436b..8b2d625912a49c 100644 --- a/examples/ota-provider-app/esp32/main/main.cpp +++ b/examples/ota-provider-app/esp32/main/main.cpp @@ -134,6 +134,7 @@ static void InitServer(intptr_t context) { otaProvider.SetQueryImageStatus(OTAQueryStatus::kUpdateAvailable); otaProvider.SetOTAFilePath(otaImagePath); + otaProvider.SetApplyUpdateAction(OTAApplyUpdateAction::kProceed); } fclose(otaImageFile); otaImageFile = NULL; diff --git a/examples/ota-requestor-app/esp32/README.md b/examples/ota-requestor-app/esp32/README.md index 4fb56712670429..25efa905180f37 100644 --- a/examples/ota-requestor-app/esp32/README.md +++ b/examples/ota-requestor-app/esp32/README.md @@ -16,7 +16,6 @@ guides to get started. - [RPC console and Device Tracing](../../../docs/guides/esp32/rpc_console.md) --- - ## Prerequisite Before moving ahead, make sure you have @@ -49,3 +48,7 @@ application of OTA image. ``` ./out/debug/chip-tool pairing onnetwork 12345 20202021 ``` + +### Note + +While trying out example ota-requestor-app change the software version from `CMakeList.txt` and not from `idf.py menuconfig` From f199dd99e1fbb36b4609b5a3a397ef30f65956f9 Mon Sep 17 00:00:00 2001 From: "Restyled.io" Date: Tue, 28 Mar 2023 05:23:28 +0000 Subject: [PATCH 2/5] Restyled by clang-format --- examples/ota-provider-app/esp32/main/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ota-provider-app/esp32/main/main.cpp b/examples/ota-provider-app/esp32/main/main.cpp index 8b2d625912a49c..82f8d52914bd17 100644 --- a/examples/ota-provider-app/esp32/main/main.cpp +++ b/examples/ota-provider-app/esp32/main/main.cpp @@ -134,7 +134,7 @@ static void InitServer(intptr_t context) { otaProvider.SetQueryImageStatus(OTAQueryStatus::kUpdateAvailable); otaProvider.SetOTAFilePath(otaImagePath); - otaProvider.SetApplyUpdateAction(OTAApplyUpdateAction::kProceed); + otaProvider.SetApplyUpdateAction(OTAApplyUpdateAction::kProceed); } fclose(otaImageFile); otaImageFile = NULL; From 875325204b071d731f24a7b3864f270df594a7a3 Mon Sep 17 00:00:00 2001 From: "Restyled.io" Date: Tue, 28 Mar 2023 05:23:29 +0000 Subject: [PATCH 3/5] Restyled by prettier-markdown --- examples/ota-requestor-app/esp32/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ota-requestor-app/esp32/README.md b/examples/ota-requestor-app/esp32/README.md index 25efa905180f37..b7b7a033dd0a55 100644 --- a/examples/ota-requestor-app/esp32/README.md +++ b/examples/ota-requestor-app/esp32/README.md @@ -16,6 +16,7 @@ guides to get started. - [RPC console and Device Tracing](../../../docs/guides/esp32/rpc_console.md) --- + ## Prerequisite Before moving ahead, make sure you have @@ -51,4 +52,5 @@ application of OTA image. ### Note -While trying out example ota-requestor-app change the software version from `CMakeList.txt` and not from `idf.py menuconfig` +While trying out example ota-requestor-app change the software version from +`CMakeList.txt` and not from `idf.py menuconfig` From 1179e3552d2a2e3b60175a1372e4c8f238313ffa Mon Sep 17 00:00:00 2001 From: Rohit Jadhav Date: Tue, 28 Mar 2023 19:02:59 +0530 Subject: [PATCH 4/5] Updated readme --- examples/ota-requestor-app/esp32/README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/ota-requestor-app/esp32/README.md b/examples/ota-requestor-app/esp32/README.md index b7b7a033dd0a55..49756f45df06da 100644 --- a/examples/ota-requestor-app/esp32/README.md +++ b/examples/ota-requestor-app/esp32/README.md @@ -52,5 +52,6 @@ application of OTA image. ### Note -While trying out example ota-requestor-app change the software version from -`CMakeList.txt` and not from `idf.py menuconfig` +While trying out example ota-requestor-app bump the software version from +`CMakeList.txt` and not from `idf.py menuconfig`. And software version of the +image which is being ota should be greater than current software version. From 80e3d43baa22aa01b37e7e936bc714c4bfd8beeb Mon Sep 17 00:00:00 2001 From: "Restyled.io" Date: Tue, 28 Mar 2023 13:36:25 +0000 Subject: [PATCH 5/5] Restyled by prettier-markdown --- examples/ota-requestor-app/esp32/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ota-requestor-app/esp32/README.md b/examples/ota-requestor-app/esp32/README.md index 49756f45df06da..734985783df06c 100644 --- a/examples/ota-requestor-app/esp32/README.md +++ b/examples/ota-requestor-app/esp32/README.md @@ -53,5 +53,5 @@ application of OTA image. ### Note While trying out example ota-requestor-app bump the software version from -`CMakeList.txt` and not from `idf.py menuconfig`. And software version of the +`CMakeList.txt` and not from `idf.py menuconfig`. And software version of the image which is being ota should be greater than current software version.