-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zap from dockerfile and update version update scripts #24732
Merged
andy31415
merged 5 commits into
project-chip:master
from
andy31415:remove_zap_from_docker
Jan 31, 2023
Merged
Remove zap from dockerfile and update version update scripts #24732
andy31415
merged 5 commits into
project-chip:master
from
andy31415:remove_zap_from_docker
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
January 30, 2023 15:12
pullapprove
bot
requested review from
msandstedt,
pjzander-signify,
rgoliver,
saurabhst and
selissia
January 30, 2023 15:12
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 30, 2023 15:12
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jan 30, 2023
PR #24732: Size comparison from 4f24db4 to 5feab21 Increases (4 builds for bl602, bl702)
Decreases (1 build for qpg)
Full report (13 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
|
PR #24732: Size comparison from 4f24db4 to 98be1d3 Increases (5 builds for bl702, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 30, 2023
bzbarsky-apple
approved these changes
Jan 30, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…-chip#24732) * Remove zap from dockerfile and update version update scripts * Documentation update * Restyle * Fix typo * Update docs/code_generation.md Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIPD now contains zap and is easier to keep up to date compared to docker files as it is on a 4hr update cron job.
Remove zap from CI, we will just use zap from CIPD from now on.
Changes: