Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register the DNS service for the accessory with a valid hostname #21985

Merged
merged 0 commits into from
Aug 17, 2022
Merged

Register the DNS service for the accessory with a valid hostname #21985

merged 0 commits into from
Aug 17, 2022

Conversation

nivi-apple
Copy link
Contributor

  • Call DNSServiceRegisterRecord to register a record for the hostname for all interfaces
    before calling DNSServiceRegister.

Problem

What is being fixed? Examples:

Change overview

Add support to register DNS service with a valid hostname that is made of a string containing MAC address and domain name.

Testing

How was this tested? (at least one bullet point required)

  • Tested using mac all-clusters-app and chip-tool. Accessory is advertising a service with the desired hostname and we are able to discover, commission and interact with the accessory.

@nivi-apple nivi-apple merged commit c037fc2 into project-chip:master Aug 17, 2022
@nivi-apple nivi-apple force-pushed the darwin_dns_sd_issue branch from c0fb8da to c037fc2 Compare August 17, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
darwin platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darwin dns-sd advertising needs to use the right hostname
1 participant
@nivi-apple