Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty out af-gen-event.h for thermostat sample #21380

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Empty out af-gen-event.h for thermostat sample #21380

merged 1 commit into from
Jul 29, 2022

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 28, 2022

Problem

The thermostat sample does not link in some configurations (ASAN):

  g++ -O0 -fPIC -Werror -Wl,--fatal-warnings -fdiagnostics-color -fsanitize=address -fno-omit-frame-pointer -Wl,--gc-sections -pie -Wl,-Map,standalone/thermostat-app.map @standalone/thermostat-app.rsp -o standalone/thermostat-app
  /usr/bin/ld: standalone/obj/src/app/util/thermostat-common.af-event.cpp.o: in function `emberAfBarrierControlClusterServerTickCallbackWrapperFunction1()':
  /ssd/src/connectedhomeip/out/debug/../../src/app/util/af-event.cpp:69: undefined reference to `emberAfBarrierControlClusterServerTickCallback(unsigned short)'

Change overview

This application does not enable the door lock or barrier control
clusters. Remove the corresponding event code.

Testing

gn_build.sh is_asan=true

@mspang
Empty out af-gen-event.h for thermostat sample
4bf1b30 
This application does not enable the door lock or barrier control
clusters. Remove the corresponding event code.

This code caused linker errors in some configurations (ASAN):

  g++ -O0 -fPIC -Werror -Wl,--fatal-warnings -fdiagnostics-color -fsanitize=address -fno-omit-frame-pointer -Wl,--gc-sections -pie -Wl,-Map,standalone/thermostat-app.map @standalone/thermostat-app.rsp -o standalone/thermostat-app
  /usr/bin/ld: standalone/obj/src/app/util/thermostat-common.af-event.cpp.o: in function `emberAfBarrierControlClusterServerTickCallbackWrapperFunction1()':
  /ssd/src/connectedhomeip/out/debug/../../src/app/util/af-event.cpp:69: undefined reference to `emberAfBarrierControlClusterServerTickCallback(unsigned short)'
@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

PR #21380: Size comparison from cc3e2b7 to 4bf1b30

Increases (4 builds for bl602, cc13x2_26x2, telink)
platform target config section cc3e2b7 4bf1b30 change % change
bl602 lighting-app bl602+rpc .text 1083552 1083556 4 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 671487 671495 8 0.0
.text 594744 594752 8 0.0
telink light-switch-app tlsr9518adk80d text 567244 567248 4 0.0
lighting-app tlsr9518adk80d text 584108 584110 2 0.0
Decreases (2 builds for cc13x2_26x2, cyw30739)
platform target config section cc3e2b7 4bf1b30 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 170048 170040 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583414 583406 -8 -0.0
.app_xip_area 460232 460224 -8 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cc3e2b7 4bf1b30 change % change
bl602 lighting-app bl602 (read/write) 1381618 1381618 0 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051888 1051888 0 0.0
bl602+rpc (read/write) 1427034 1427034 0 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083552 1083556 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668523 668523 0 0.0
(read/write) 182820 182820 0 0.0
.bss 74236 74236 0 0.0
.data 3372 3372 0 0.0
.rodata 88195 88195 0 0.0
.text 580012 580012 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634107 634107 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73532 73532 0 0.0
.data 3372 3372 0 0.0
.rodata 77411 77411 0 0.0
.text 556372 556372 0 0.0
lock-ftd LP_CC2652R7 (read only) 671487 671495 8 0.0
(read/write) 170048 170040 -8 -0.0
.bss 71316 71316 0 0.0
.data 3296 3296 0 0.0
.rodata 76263 76263 0 0.0
.text 594744 594752 8 0.0
lock-mtd LP_CC2652R7 (read only) 653595 653595 0 0.0
(read/write) 183628 183628 0 0.0
.bss 67004 67004 0 0.0
.data 3296 3296 0 0.0
.rodata 100875 100875 0 0.0
.text 552240 552240 0 0.0
pump-app LP_CC2652R7 (read only) 680959 680959 0 0.0
(read/write) 161408 161408 0 0.0
.bss 71380 71380 0 0.0
.data 3296 3296 0 0.0
.rodata 88863 88863 0 0.0
.text 591612 591612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666527 666527 0 0.0
(read/write) 175976 175976 0 0.0
.bss 71516 71516 0 0.0
.data 3292 3292 0 0.0
.rodata 84679 84679 0 0.0
.text 581368 581368 0 0.0
shell LP_CC2652R7 (read only) 661206 661206 0 0.0
(read/write) 185656 185656 0 0.0
.bss 76556 76556 0 0.0
.data 3376 3376 0 0.0
.rodata 85166 85166 0 0.0
.text 575724 575724 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583414 583406 -8 -0.0
.app_xip_area 460232 460224 -8 -0.0
.bss 65624 65624 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589158 589158 0 0.0
.app_xip_area 461248 461248 0 0.0
.bss 70352 70352 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588970 588970 0 0.0
.app_xip_area 466604 466604 0 0.0
.bss 64864 64864 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088048 1088048 0 0.0
.bss 133260 133260 0 0.0
.data 2064 2064 0 0.0
.text 952704 952704 0 0.0
BRD4161A+rpc (read/write) 1142356 1142356 0 0.0
.bss 149940 149940 0 0.0
.data 2276 2276 0 0.0
.text 990120 990120 0 0.0
BRD4161A+rs911x (read/write) 973912 973912 0 0.0
.bss 161736 161736 0 0.0
.data 2048 2048 0 0.0
.text 810108 810108 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128392 1128392 0 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981948 981948 0 0.0
window-app BRD4161A (read/write) 1081316 1081316 0 0.0
.bss 134732 134732 0 0.0
.data 2092 2092 0 0.0
.text 944468 944468 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022808 1022808 0 0.0
(read/write) 1486274 1486274 0 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 215936 0 0.0
.flash.text 1022808 1022808 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076295 1076295 0 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246364 0 0.0
.flash.text 1070911 1070911 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642800 642800 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568316 568316 0 0.0
lock k32w0+release (read/write) 699920 699920 0 0.0
.bss 70152 70152 0 0.0
.data 2052 2052 0 0.0
.text 624988 624988 0 0.0
linux all-clusters-app debug (read only) 2991257 2991257 0 0.0
(read/write) 155584 155584 0 0.0
.bss 61888 61888 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 269195 269195 0 0.0
.text 2543490 2543490 0 0.0
all-clusters-minimal-app debug (read only) 2834297 2834297 0 0.0
(read/write) 147288 147288 0 0.0
.bss 61088 61088 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 269355 269355 0 0.0
.text 2388978 2388978 0 0.0
bridge-app debug+rpc (read only) 2352649 2352649 0 0.0
(read/write) 127160 127160 0 0.0
.bss 50176 50176 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201480 201480 0 0.0
.text 1988402 1988402 0 0.0
chip-tool debug (read only) 10466289 10466289 0 0.0
(read/write) 641464 641464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 606824 606824 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535989 535989 0 0.0
.text 8445892 8445892 0 0.0
chip-tool-ipv6only arm64 (read only) 9881988 9881988 0 0.0
(read/write) 689041 689041 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 634336 634336 0 0.0
.dynamic 560 560 0 0.0
.got 13584 13584 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468196 468196 0 0.0
.text 7798660 7798660 0 0.0
lighting-app debug+rpc (read only) 2575513 2575513 0 0.0
(read/write) 130096 130096 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217232 217232 0 0.0
.text 2187426 2187426 0 0.0
lock-app debug (read only) 2539617 2539617 0 0.0
(read/write) 125176 125176 0 0.0
.bss 48160 48160 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 232112 232112 0 0.0
.text 2141426 2141426 0 0.0
ota-provider-app debug (read only) 2343961 2343961 0 0.0
(read/write) 118944 118944 0 0.0
.bss 47776 47776 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207704 207704 0 0.0
.text 1972594 1972594 0 0.0
ota-requestor-app debug (read only) 2464873 2464873 0 0.0
(read/write) 126304 126304 0 0.0
.bss 50144 50144 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211264 211264 0 0.0
.text 2081330 2081330 0 0.0
shell debug (read only) 2574785 2574785 0 0.0
(read/write) 141736 141736 0 0.0
.bss 57736 57736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231282 231282 0 0.0
.text 2185442 2185442 0 0.0
thermostat-no-ble arm64 (read only) 2343516 2343516 0 0.0
(read/write) 141633 141633 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 138964 138964 0 0.0
.text 1967312 1967312 0 0.0
tv-app debug (read only) 3147041 3147041 0 0.0
(read/write) 257640 257640 0 0.0
.bss 167320 167320 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79032 79032 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 255240 255240 0 0.0
.text 2702418 2702418 0 0.0
tv-casting-app debug (read only) 5382121 5382121 0 0.0
(read/write) 158592 158592 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338641 338641 0 0.0
.text 4776402 4776402 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450672 2450672 0 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413316 1413316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172931 1172931 0 0.0
bss 143120 143120 0 0.0
rodata 141828 141828 0 0.0
text 809028 809028 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152967 1152967 0 0.0
bss 142356 142356 0 0.0
rodata 133360 133360 0 0.0
text 798336 798336 0 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686972 1686972 0 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526800 1526800 0 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1631084 1631084 0 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471632 1471632 0 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552492 1552492 0 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401344 1401344 0 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589908 1589908 0 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434288 1434288 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799608 799608 0 0.0
bss 70796 70796 0 0.0
noinit 40416 40416 0 0.0
text 567244 567248 4 0.0
lighting-app tlsr9518adk80d (read/write) 820024 820024 0 0.0
bss 71640 71640 0 0.0
noinit 40416 40416 0 0.0
text 584108 584110 2 0.0

@mspang mspang enabled auto-merge (squash) July 29, 2022 03:16
@mspang mspang merged commit 375e841 into project-chip:master Jul 29, 2022
@mspang mspang deleted the for-chip/af-events-remove branch July 29, 2022 08:20
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@mspang @isiu-apple
Empty out af-gen-event.h for thermostat sample (project-chip#21380)
d2d3b45 
This application does not enable the door lock or barrier control
clusters. Remove the corresponding event code.

This code caused linker errors in some configurations (ASAN):

  g++ -O0 -fPIC -Werror -Wl,--fatal-warnings -fdiagnostics-color -fsanitize=address -fno-omit-frame-pointer -Wl,--gc-sections -pie -Wl,-Map,standalone/thermostat-app.map @standalone/thermostat-app.rsp -o standalone/thermostat-app
  /usr/bin/ld: standalone/obj/src/app/util/thermostat-common.af-event.cpp.o: in function `emberAfBarrierControlClusterServerTickCallbackWrapperFunction1()':
  /ssd/src/connectedhomeip/out/debug/../../src/app/util/af-event.cpp:69: undefined reference to `emberAfBarrierControlClusterServerTickCallback(unsigned short)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mspang @bzbarsky-apple @Damian-Nordic