Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casting lifecycle issues #20138

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix casting lifecycle issues #20138

merged 1 commit into from
Jun 30, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

Change overview

  • generate a random nodeId for each casting app
  • grab validated vid/pid from CommissioningDelegate rather than one from UDC request

Testing

  • Tested using tv-casting-app and tv-app

@github-actions
Copy link

github-actions bot commented Jun 29, 2022

PR #20138: Size comparison from 9d2eeb0 to c6ea4f9

Increases (1 build for nrfconnect)
platform target config section 9d2eeb0 c6ea4f9 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809772 809776 4 0.0
Full report (8 builds for efr32, mbed, nrfconnect)
platform target config section 9d2eeb0 c6ea4f9 change % change
efr32 lighting-app BRD4161A (read/write) 1080060 1080060 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 944996 944996 0 0.0
BRD4161A+rpc (read/write) 1134356 1134356 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982400 982400 0 0.0
BRD4161A+rs911x (read/write) 942524 942524 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801744 801744 0 0.0
lock-app BRD4161A+wf200 (read/write) 1119568 1119568 0 0.0
.bss 139144 139144 0 0.0
.data 2060 2060 0 0.0
.text 978344 978344 0 0.0
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1172915 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809772 809776 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799484 799484 0 0.0

@chrisdecenzo chrisdecenzo merged commit 39a8af0 into master Jun 30, 2022
@chrisdecenzo chrisdecenzo deleted the tvapps-android15 branch June 30, 2022 12:22
@chrisdecenzo chrisdecenzo restored the tvapps-android15 branch July 26, 2022 20:48
@chrisdecenzo chrisdecenzo deleted the tvapps-android15 branch December 28, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting Video Player - client lifecycle issues
3 participants