Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused configuration items from ConfigurationMgr #13672

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Remove unused configuration items from ConfigurationMgr #13672

merged 1 commit into from
Jan 19, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • We have decided to use use NVM attribute storage instead of configuration manager and attribute access override to implement HourFormat and CalendarType attributes, this will prevent us having per-platform implementations.

Change overview

Remove unused configuration items from ConfigurationMgr

Testing

How was this tested? (at least one bullet point required)

  • Cleanup unused code only

@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited
Loading

PR #13672: Size comparison from 78a6636 to 2eab814

Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 78a6636 2eab814 change % change
efr32 lighting-app BRD4161A (read only) 834948 834772 -176 -0.0
.text 834940 834764 -176 -0.0
BRD4161A+rpc (read only) 822352 822160 -192 -0.0
.text 822344 822152 -192 -0.0
window-app BRD4161A (read only) 805536 805344 -192 -0.0
.text 805528 805336 -192 -0.0
esp32 all-clusters-app c3devkit (read only) 912452 912284 -168 -0.0
(read/write) 1316698 1316642 -56 -0.0
.dram0.data 14292 14276 -16 -0.1
.flash.rodata 178384 178344 -40 -0.0
.flash.text 912452 912284 -168 -0.0
m5stack (read only) 961295 961123 -172 -0.0
(read/write) 448856 448800 -56 -0.0
.flash.rodata 207672 207616 -56 -0.0
.flash.text 955911 955739 -172 -0.0
k32w light k32w061+release (read/write) 659156 659028 -128 -0.0
.text 574360 574232 -128 -0.0
lock k32w061+release (read/write) 661888 661760 -128 -0.0
.text 576776 576648 -128 -0.0
linux chip-tool-ipv6only arm64 (read only) 8090660 8089748 -912 -0.0
(read/write) 373409 373329 -80 -0.0
.data.rel.ro 248088 248024 -64 -0.0
.got 65296 65280 -16 -0.0
.rodata 421100 421068 -32 -0.0
.text 6873764 6873124 -640 -0.0
thermostat-no-ble arm64 (read only) 2044156 2043260 -896 -0.0
(read/write) 145985 145905 -80 -0.1
.data.rel.ro 73016 72952 -64 -0.1
.got 4048 4032 -16 -0.4
.rodata 129932 129916 -16 -0.0
.text 1699616 1698976 -640 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350176 2349968 -208 -0.0
.text 1312752 1312544 -208 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334632 2334360 -272 -0.0
.text 1297232 1296960 -272 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304984 2304768 -216 -0.0
.text 1267584 1267368 -216 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054464 2054256 -208 -0.0
.text 1017064 1016856 -208 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943315 -176 -0.0
rodata 108824 108760 -64 -0.1
text 637456 637340 -116 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 928799 -176 -0.0
rodata 101276 101212 -64 -0.1
text 632852 632732 -120 -0.0
nrf52840dongle_nrf52840 (read/write) 994171 993995 -176 -0.0
rodata 113580 113516 -64 -0.1
text 669656 669536 -120 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853334 853142 -192 -0.0
rodata 102000 101936 -64 -0.1
text 554380 554260 -120 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912675 -176 -0.0
rodata 103792 103728 -64 -0.1
text 612904 612788 -116 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822746 -176 -0.0
rodata 97020 96956 -64 -0.1
text 529864 529744 -120 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 915719 915527 -192 -0.0
rodata 104156 104092 -64 -0.1
text 615556 615436 -120 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910611 -176 -0.0
rodata 103264 103200 -64 -0.1
text 611480 611364 -116 -0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798479 -176 -0.0
rodata 78388 78324 -64 -0.1
text 533992 533880 -112 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711294 -176 -0.0
rodata 72688 72624 -64 -0.1
text 451668 451556 -112 -0.0
p6 all-clusters-app default (read/write) 2405304 2405056 -248 -0.0
.text 1363568 1363320 -248 -0.0
light-app default (read/write) 2330160 2329928 -232 -0.0
.text 1288424 1288192 -232 -0.0
lock-app default (read/write) 2299168 2298936 -232 -0.0
.text 1257432 1257200 -232 -0.0
qpg lighting-app qpg6105+debug (read only) 565160 565040 -120 -0.0
.text 559840 559720 -120 -0.0
lock-app qpg6105+debug (read only) 515572 515452 -120 -0.0
.text 510252 510132 -120 -0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840674 -228 -0.0
text 587854 587698 -156 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 78a6636 2eab814 change % change
efr32 lighting-app BRD4161A (read only) 834948 834772 -176 -0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834940 834764 -176 -0.0
BRD4161A+rpc (read only) 822352 822160 -192 -0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822344 822152 -192 -0.0
window-app BRD4161A (read only) 805536 805344 -192 -0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805528 805336 -192 -0.0
esp32 all-clusters-app c3devkit (read only) 912452 912284 -168 -0.0
(read/write) 1316698 1316642 -56 -0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14292 14276 -16 -0.1
.flash.rodata 178384 178344 -40 -0.0
.flash.text 912452 912284 -168 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961295 961123 -172 -0.0
(read/write) 448856 448800 -56 -0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207672 207616 -56 -0.0
.flash.text 955911 955739 -172 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659156 659028 -128 -0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574360 574232 -128 -0.0
lock k32w061+release (read/write) 661888 661760 -128 -0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576776 576648 -128 -0.0
linux chip-tool-ipv6only arm64 (read only) 8090660 8089748 -912 -0.0
(read/write) 373409 373329 -80 -0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248088 248024 -64 -0.0
.dynamic 560 560 0 0.0
.got 65296 65280 -16 -0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 421100 421068 -32 -0.0
.text 6873764 6873124 -640 -0.0
thermostat-no-ble arm64 (read only) 2044156 2043260 -896 -0.0
(read/write) 145985 145905 -80 -0.1
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 73016 72952 -64 -0.1
.dynamic 560 560 0 0.0
.got 4048 4032 -16 -0.4
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129932 129916 -16 -0.0
.text 1699616 1698976 -640 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350176 2349968 -208 -0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312752 1312544 -208 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334632 2334360 -272 -0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297232 1296960 -272 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304984 2304768 -216 -0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267584 1267368 -216 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054256 -208 -0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1016856 -208 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943315 -176 -0.0
bss 119628 119628 0 0.0
rodata 108824 108760 -64 -0.1
text 637456 637340 -116 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 928799 -176 -0.0
bss 116672 116672 0 0.0
rodata 101276 101212 -64 -0.1
text 632852 632732 -120 -0.0
nrf52840dongle_nrf52840 (read/write) 994171 993995 -176 -0.0
bss 122472 122472 0 0.0
rodata 113580 113516 -64 -0.1
text 669656 669536 -120 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853334 853142 -192 -0.0
bss 116416 116416 0 0.0
rodata 102000 101936 -64 -0.1
text 554380 554260 -120 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912675 -176 -0.0
bss 118784 118784 0 0.0
rodata 103792 103728 -64 -0.1
text 612904 612788 -116 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822746 -176 -0.0
bss 115600 115600 0 0.0
rodata 97020 96956 -64 -0.1
text 529864 529744 -120 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915719 915527 -192 -0.0
bss 118548 118548 0 0.0
rodata 104156 104092 -64 -0.1
text 615556 615436 -120 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910611 -176 -0.0
bss 118572 118572 0 0.0
rodata 103264 103200 -64 -0.1
text 611480 611364 -116 -0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798479 -176 -0.0
bss 109776 109776 0 0.0
rodata 78388 78324 -64 -0.1
text 533992 533880 -112 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711294 -176 -0.0
bss 107664 107664 0 0.0
rodata 72688 72624 -64 -0.1
text 451668 451556 -112 -0.0
p6 all-clusters-app default (read/write) 2405304 2405056 -248 -0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363568 1363320 -248 -0.0
light-app default (read/write) 2330160 2329928 -232 -0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288424 1288192 -232 -0.0
lock-app default (read/write) 2299168 2298936 -232 -0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257432 1257200 -232 -0.0
qpg lighting-app qpg6105+debug (read only) 565160 565040 -120 -0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559840 559720 -120 -0.0
lock-app qpg6105+debug (read only) 515572 515452 -120 -0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510252 510132 -120 -0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840674 -228 -0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587854 587698 -156 -0.0

@andy31415
Copy link
Contributor

fast track: cleanup pr that has been up sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 5274676 into project-chip:master Jan 19, 2022
@yufengwangca yufengwangca deleted the pr/configuration/cleanup branch January 19, 2022 23:47
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@yufengwangca @selissia
Remove unused configuration items from ConfigurationMgr (project-chip…
9d97a09 
…#13672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin efr32 esp32 fast track linux platform review - pending zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yufengwangca @andy31415