Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the dedicated pool for global dirty path list using object pool #9551

Closed
yunhanw-google opened this issue Sep 8, 2021 · 3 comments
Closed
Assignees

Comments

@yunhanw-google
Copy link
Contributor

I also don't think it's a wise idea to have this global dirty rely on the same ClusterInfo resource pool that is used for allocating paths on incoming subscribe/read processing. This couples one onto the other - if there are a large number of subscribers who use up the majority of the pool, your dirty tracking system is not going to function well, if it all.

They have separate purposes, so having separate pools would be more sensible. Fine to do this as a follow-up issue.

Originally posted by @mrjerryjohns in #9510 (comment)

@yunhanw-google yunhanw-google changed the title Create the dedicated pool for global dirty path list Create the dedicated pool for global dirty path list using object pool Sep 8, 2021
@yunhanw-google yunhanw-google self-assigned this Sep 8, 2021
@mrjerryjohns mrjerryjohns added p1 priority 1 work TE7.5 labels Nov 19, 2021
@mrjerryjohns
Copy link
Contributor

This is pretty important to get a functioning subscription going.

@tcarmelveilleux
Copy link
Contributor

@mrjerryjohns Says it's done

@mrjerryjohns
Copy link
Contributor

Implemented in #13472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants